refactor(server): remove unnecessary update listening mechanisms

Author: xeruf

sdk/src/server-api/sc/networking/clients/ControllingClient.java

@@ -2,7 +2,6 @@
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-
 import sc.framework.plugins.Player;
 import sc.protocol.requests.CancelRequest;
 import sc.protocol.requests.PauseGameRequest;
@@ -99,7 +98,6 @@ public void cancel() {
   public void onGamePaused(String roomId, Player nextPlayer) {
     logger.info("A PAUSE HIT was detected.");
     this.pauseHitReceived = true;
-    this.notifyOnUpdate();
   }
 
   @Override

sdk/src/server-api/sc/networking/clients/IControllableGame.java

@@ -0,0 +1,25 @@
+package sc.networking.clients
+
+import sc.shared.GameResult
+
+interface IControllableGame {
+    fun next()
+    fun hasNext(): Boolean
+    
+    fun previous()
+    fun pause()
+    fun unpause()
+    fun hasPrevious(): Boolean
+    val isPaused: Boolean
+    fun cancel()
+    val currentState: Any?
+    val currentError: Any?
+    val isAtEnd: Boolean
+    val isAtStart: Boolean
+    fun goToFirst()
+    fun goToLast()
+    fun canTogglePause(): Boolean
+    val result: GameResult?
+    val isGameOver: Boolean
+    val isReplay: Boolean
+}

sdk/src/server-api/sc/networking/clients/IControllableGame.kt

@@ -2,8 +2,6 @@
 
 public interface IPollsHistory {
   void start();
-
   void addListener(IHistoryListener listener);
-
   void removeListener(IHistoryListener listener);
 }

sdk/src/server-api/sc/networking/clients/IPollsHistory.java

@@ -28,7 +28,6 @@ public ObservingClient(String roomId, boolean isPaused) {
   private boolean gameOver = false;
 
   private final List<ProtocolMessage> history = new ArrayList<>();
-  private final List<IUpdateListener> listeners = new ArrayList<>();
 
   private GameResult result = null;
 
@@ -54,37 +53,13 @@ public void onNewState(String roomId, IGameState state) {
       logger.debug("{} got new state {}", this, state);
     if (isAffected(roomId)) {
       addObservation(state);
-      notifyOnUpdate();
     }
   }
 
   protected boolean isAffected(String roomId) {
     return this.replay || this.roomId.equals(roomId);
   }
 
-  protected void notifyOnUpdate() {
-    for (IUpdateListener listener : this.listeners) {
-      listener.onUpdate(this);
-    }
-  }
-
-  protected void notifyOnError(String errorMessage) {
-    for (IUpdateListener listener : this.listeners) {
-      listener.onError(errorMessage);
-    }
-  }
-
-  @Override
-  public void removeListener(IUpdateListener u) {
-    this.listeners.remove(u);
-  }
-
-  @Override
-  public void addListener(IUpdateListener u) {
-    this.listeners.add(u);
-    u.onUpdate(this);
-  }
-
   @Override
   public void next() {
     this.changePosition(+1);
@@ -93,7 +68,6 @@ public void next() {
   @Override
   public void pause() {
     paused = true;
-    notifyOnUpdate();
   }
 
   @Override
@@ -129,7 +103,6 @@ protected void setPosition(int i) {
     logger.debug("Setting Position to {} (requested {})", newPosition, i);
     if (newPosition != this.position) {
       this.position = newPosition;
-      notifyOnUpdate();
     }
   }
 
@@ -204,8 +177,6 @@ public void onGameOver(String roomId, GameResult result) {
 
     this.gameOver = true;
     this.result = result;
-
-    notifyOnUpdate();
   }
 
   @Override
@@ -244,7 +215,6 @@ public void onGameError(String roomId, ProtocolErrorMessage error) {
       logger.debug("{} (room: {})", error.getLogMessage(), roomId);
     if (isAffected(roomId)) {
       addObservation(error);
-      notifyOnError(error.getMessage());
     }
   }