refactor(sdk): convert SlotDescriptor to kotlin

It also moves the "static default SlotDescriptor" to SlotDescriptor's
default arguments.
here's no need for a "default object"

Author: anarchuser

server/src/sc/server/gaming/PlayerSlot.java

@@ -17,6 +17,7 @@ public PlayerSlot(GameRoom room) {
       throw new IllegalStateException("Room must not be null.");
 
     this.room = room;
+    descriptor = new SlotDescriptor();
   }
 
   public PlayerRole getRole() {
@@ -85,15 +86,12 @@ public String getDisplayName() {
   }
 
   public SlotDescriptor getDescriptor() {
-    if (this.descriptor == null) {
-      return SlotDescriptor.DEFAULT_DESCRIPTOR;
-    }
-
     return this.descriptor;
   }
 
   public void setDescriptor(SlotDescriptor descriptor) {
-    this.descriptor = descriptor;
+    if (descriptor == null) this.descriptor = new SlotDescriptor();
+    else this.descriptor = descriptor;
   }
 
   public IClient getClient() {

socha-sdk/src/framework/sc/shared/SlotDescriptor.java

@@ -0,0 +1,19 @@
+package sc.shared
+
+import com.thoughtworks.xstream.annotations.XStreamAlias
+import com.thoughtworks.xstream.annotations.XStreamAsAttribute
+
+@XStreamAlias(value = "slotDescriptor")
+class SlotDescriptor(
+        @XStreamAsAttribute val displayName: String,
+        @XStreamAsAttribute val canTimeout: Boolean,
+        @XStreamAsAttribute val shouldBePaused: Boolean) {
+    
+    constructor(displayName: String, canTimeout: Boolean) : this(displayName, canTimeout, true)
+    constructor(displayName: String) : this(displayName, true, true)
+    constructor() : this("Unknown", true, true)
+    
+    override fun toString(): String {
+        return "SlotDescriptor{displayName=$displayName, canTimeout=$canTimeout, shouldBePaused=$shouldBePaused"
+    }
+}

socha-sdk/src/framework/sc/shared/SlotDescriptor.kt

@@ -18,7 +18,7 @@ class SlotDescriptorTest : StringSpec({
                 SlotDescriptor("another name", true, false)
         )
         val XMLs = listOf(
-                """<slotDescriptor canTimeout="false" shouldBePaused="false"/>""",
+                """<slotDescriptor displayName="Unknown" canTimeout="true" shouldBePaused="true"/>""",
                 """<slotDescriptor displayName="Display Name" canTimeout="true" shouldBePaused="true"/>""",
                 """<slotDescriptor displayName="name" canTimeout="false" shouldBePaused="true"/>""",
                 """<slotDescriptor displayName="another name" canTimeout="true" shouldBePaused="false"/>"""