fix(network/LobbyClient): prevent ConcurrentModificationExceptions

xeruf · xeruf · commit 6f5680182b25 · 2021-04-28T18:36:23.000+02:00
diff --git a/sdk/src/server-api/sc/networking/clients/LobbyClient.java b/sdk/src/server-api/sc/networking/clients/LobbyClient.java
@@ -103,7 +103,7 @@ private void onGameLeft(String roomId) {
   }
 
   private void onGameJoined(String roomId) {
-    for (ILobbyClientListener listener : this.listeners) {
+    for (ILobbyClientListener listener : new ArrayList<>(this.listeners)) {
       listener.onGameJoined(roomId);
     }
   }
@@ -116,7 +116,7 @@ private void onGameObserved(String roomId) {
 
 
   protected void onGamePrepared(GamePreparedResponse response) {
-    for (ILobbyClientListener listener : this.listeners) {
+    for (ILobbyClientListener listener : new ArrayList<>(this.listeners)) {
       listener.onGamePrepared(response);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ private void onGameLeft(String roomId) {`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`private void onGameJoined(String roomId) {`
`106`		`- for (ILobbyClientListener listener : this.listeners) {`
	`106`	`+ for (ILobbyClientListener listener : new ArrayList<>(this.listeners)) {`
`107`	`107`	`listener.onGameJoined(roomId);`
`108`	`108`	`}`
`109`	`109`	`}`
`@@ -116,7 +116,7 @@ private void onGameObserved(String roomId) {`
`116`	`116`
`117`	`117`
`118`	`118`	`protected void onGamePrepared(GamePreparedResponse response) {`
`119`		`- for (ILobbyClientListener listener : this.listeners) {`
	`119`	`+ for (ILobbyClientListener listener : new ArrayList<>(this.listeners)) {`
`120`	`120`	`listener.onGamePrepared(response);`
`121`	`121`	`}`
`122`	`122`	`}`