Skip to content

Commit 517f61e

Browse files
committed
chore(gradle): remove xmlpull and document update issues
1 parent e2a37e1 commit 517f61e

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

GUIDELINES.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,18 @@
22

33
This document captures development standards and architecture decisions of this project as a point of reference.
44

5+
## Gradle
6+
7+
We build everything with gradle, nesting projects if needed.
8+
Currently we have some pending updates, due to the following incompatibilities:
9+
10+
- The new johnrengelman.shadow plugin version needs Gradle 7
11+
- The current Dokka version can neither handle Gradle 7 nor Kotlin 1.5.30+ nor Java beyond version 8
12+
13+
The bottleneck is updating dokka,
14+
which is a longer process tracked in
15+
https://github.com/software-challenge/backend/pull/404
16+
517
## Testing
618

719
Unsere Unittests nutzen das [Kotest-Framework](https://kotest.io)
@@ -41,7 +53,7 @@ annotate the serialized fields with a concrete type instead.
4153
Ideally these fields should then be private with generically typed getters
4254
as to not expose the implementation details internally.
4355

44-
## Cloning
56+
## Object Cloning
4557

4658
Relevant discussion: https://github.com/software-challenge/backend/pull/148
4759

sdk/build.gradle.kts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ configurations {
1717
}
1818

1919
artifacts {
20-
val kt = tasks["compileTestConfigKotlin"]
20+
val kt = tasks.getByName("compileTestConfigKotlin", org.jetbrains.kotlin.gradle.tasks.KotlinCompile::class)
2121
add("testConfig", kt.outputs.files.first()) {
2222
builtBy(kt)
2323
}
@@ -26,13 +26,12 @@ configurations.archives.get().artifacts.removeIf { it.name == "testConfig" }
2626

2727
dependencies {
2828
api(kotlin("stdlib"))
29-
api("com.thoughtworks.xstream", "xstream", "1.4.17") // New security config for 1.4.20
29+
api("com.thoughtworks.xstream", "xstream", "1.4.19") // New security config for 1.4.20
3030
api("jargs", "jargs", "1.0")
3131
api("org.slf4j", "slf4j-api", "2.0.9")
3232

3333
implementation("org.hamcrest", "hamcrest-core", "2.2")
3434
implementation("net.sf.kxml", "kxml2", "2.3.0")
35-
implementation("xmlpull", "xmlpull", "1.1.3.1")
3635

3736
"testConfigApi"("io.kotest", "kotest-assertions-core")
3837
"testConfigApi"("io.kotest", "kotest-runner-junit5-jvm", "5.0.3")

sdk/src/test/config/KotestConfig.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import io.kotest.core.spec.IsolationMode
55
import io.kotest.core.test.TestCaseOrder
66
import kotlin.time.Duration.Companion.seconds
77

8+
@OptIn(ExperimentalTime::class)
89
object KotestConfig: AbstractProjectConfig() {
910
override val parallelism = Runtime.getRuntime().availableProcessors()
1011

0 commit comments

Comments
 (0)