fix(client): make roomId nullable in onError

Author: xeruf

plugin/src/client/sc/plugin2021/AbstractClient.kt

@@ -69,8 +69,8 @@ abstract class AbstractClient(
             client.sendMessageToRoom(roomId, move)
 
     /** Called when an erroneous message is sent to the room. */
-    override fun onError(roomId: String, error: ProtocolErrorMessage) {
-        logger.debug("onError: Client $this received error ${error.message}")
+    override fun onError(roomId: String?, error: ProtocolErrorMessage) {
+        logger.debug("onError: Client $this received error ${error.message} in $roomId")
         this.error = error.message
     }
 

sdk/src/server-api/sc/networking/clients/AbstractLobbyClientListener.kt

@@ -10,7 +10,7 @@ import sc.shared.GameResult
 abstract class AbstractLobbyClientListener: ILobbyClientListener {
     override fun onNewState(roomId: String, state: IGameState) {}
     override fun onRoomMessage(roomId: String, data: ProtocolMessage) {}
-    override fun onError(roomId: String, error: ProtocolErrorMessage) {}
+    override fun onError(roomId: String?, error: ProtocolErrorMessage) {}
     override fun onGamePrepared(response: GamePreparedResponse) {}
     override fun onGameLeft(roomId: String) {}
     override fun onGameJoined(roomId: String) {}

sdk/src/server-api/sc/networking/clients/ILobbyClientListener.kt

@@ -12,7 +12,7 @@ import sc.shared.GameResult
 interface ILobbyClientListener {
     fun onNewState(roomId: String, state: IGameState)
     fun onRoomMessage(roomId: String, data: ProtocolMessage)
-    fun onError(roomId: String, error: ProtocolErrorMessage)
+    fun onError(roomId: String?, error: ProtocolErrorMessage)
     fun onGamePrepared(response: GamePreparedResponse)
     fun onGameLeft(roomId: String)
     fun onGameJoined(roomId: String)