fix

Charlie17Li · Charlie17Li · commit afc388fd2bf4 · 2023-11-20T15:10:14.000+08:00
diff --git a/module-controller/internal/controller/moduledeployment_controller.go b/module-controller/internal/controller/moduledeployment_controller.go
@@ -91,7 +91,6 @@ func (r *ModuleDeploymentReconciler) Reconcile(ctx context.Context, req ctrl.Req
 			}
 			return ctrl.Result{}, nil
 		}
-
 	}
 
 	if moduleDeployment.Generation == 1 {
@@ -278,6 +277,7 @@ func (r *ModuleDeploymentReconciler) updateOwnerReference(ctx context.Context, m
 	})
 	moduleDeployment.SetOwnerReferences(ownerReference)
 	utils.AddFinalizer(&moduleDeployment.ObjectMeta, finalizer.ModuleReplicaSetExistedFinalizer)
+	utils.AddFinalizer(&moduleDeployment.ObjectMeta, finalizer.ModuleExistedFinalizer)
 	err = utils.UpdateResource(r.Client, ctx, moduleDeployment)
 	if err != nil {
 		return utils.Error(err, "Failed to update moduleDeployment", "moduleDeploymentName", moduleDeployment.Name)

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,6 @@ func (r *ModuleDeploymentReconciler) Reconcile(ctx context.Context, req ctrl.Req`
`91`	`91`	`}`
`92`	`92`	`return ctrl.Result{}, nil`
`93`	`93`	`}`
`94`		`-`
`95`	`94`	`}`
`96`	`95`
`97`	`96`	`if moduleDeployment.Generation == 1 {`
`@@ -278,6 +277,7 @@ func (r *ModuleDeploymentReconciler) updateOwnerReference(ctx context.Context, m`
`278`	`277`	`})`
`279`	`278`	`moduleDeployment.SetOwnerReferences(ownerReference)`
`280`	`279`	`utils.AddFinalizer(&moduleDeployment.ObjectMeta, finalizer.ModuleReplicaSetExistedFinalizer)`
	`280`	`+ utils.AddFinalizer(&moduleDeployment.ObjectMeta, finalizer.ModuleExistedFinalizer)`
`281`	`281`	`err = utils.UpdateResource(r.Client, ctx, moduleDeployment)`
`282`	`282`	`if err != nil {`
`283`	`283`	`return utils.Error(err, "Failed to update moduleDeployment", "moduleDeploymentName", moduleDeployment.Name)`