refactor(repl): block window functions that do not work in headless mode

Author: jwerle

bin/repl.js

@@ -230,6 +230,12 @@ async function evaluate (cmd, ctx, file, callback) {
     for (const node of root) {
       if (node.id?.name) {
         names.push(node.id.name)
+      } else if (node.declarations) {
+        for (const declaration of node.declarations) {
+          if (declaration.id?.name) {
+            names.push(declaration.id.name)
+          }
+        }
       } else {
         names.push(null)
       }
@@ -245,7 +251,10 @@ async function evaluate (cmd, ctx, file, callback) {
     } else if (lastName) {
       cmd = `${cmd}; io.util.format(${lastName});`
     } else if (!/^\s*((throw\s)|(with\s*\()|(try\s*{)|(const\s)|(let\s)|(var\s)|(if\s*\()|(for\s*\()|(while\s*\()|(do\s*{)|(return\s)|(import\s*\())/.test(cmd)) {
-      cmd = `io.util.format(${cmd});`
+      cmd = cmd.split(';').map((c) => {
+        if (/^\s*\{/.test(c)) { return c }
+        return `io.util.format(${c});`
+      }).join('\n')
     }
   }
 

repl/context.js

@@ -30,8 +30,30 @@ export function init (opts) {
 
   didInit = true
 
+  const disabledFunctions = [
+    'alert',
+    'blur',
+    'close',
+    'confirm',
+    'focus',
+    'moveBy',
+    'moveTo',
+    'openDialog',
+    'print',
+    'prompt',
+    'resizeBy',
+    'resizeTo',
+    'scrollTo',
+    'scroll',
+    'stop'
+  ]
+
   window.io = io
 
+  for (const fn of disabledFunctions) {
+    window[fn] = () => console.warn(`WARN: ${fn}() is not available in the REPL context`)
+  }
+
   for (const key in io) {
     if (window[key] !== undefined) { continue }
     Object.defineProperty(window, key, {
@@ -89,15 +111,17 @@ function makeError (err) {
 export async function evaluate ({ cmd, id }) {
   try {
     if (/\s*await\s*import\s*\(/.test(cmd)) {
-      const value = await new AsyncFunction(`return (${cmd})`)()
+      cmd = cmd.replace(/^\s*(let|const|var)\s+/, '')
+      const value = await new AsyncFunction(`(${cmd})`)()
       await ipc.send('repl.eval.result', {
         id,
         error: false,
         value: JSON.stringify({ data: io.util.format(value) })
       })
       return
     } else if (/\s*import\s*\(/.test(cmd)) {
-      const value = new AsyncFunction(`return (${cmd})`)()
+      cmd = cmd.replace(/^\s*(let|const|var)\s+/, '')
+      const value = new AsyncFunction(`(${cmd})`)()
       await ipc.send('repl.eval.result', {
         id,
         error: false,