Commit f9cb983
committed
fix(engine.io-parser): do not expose the TransformStream type
The previous commit [1] tried to work around the fact that the
TransformStream object is not exposed in the global scope in the
`@types/node` package, even though it is since Node.js `v18.0.0`.
Unfortunately, it created two new issues:
- using an older `@types/node` version (before v16) would fail with:
> error TS2307: Cannot find module 'node:stream/web' or its corresponding type declarations.
Related: #5064 (comment)
- browser-only environments would somehow include the node types,
leading to conflicts like the return value of the setTimeout() method
Related:
- #5064 (comment)
- #5065
[1]: socketio/engine.io-parser@0305b4a1 parent 04033b2 commit f9cb983
1 file changed
+2
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | 10 | | |
14 | 11 | | |
15 | 12 | | |
| |||
49 | 46 | | |
50 | 47 | | |
51 | 48 | | |
52 | | - | |
53 | | - | |
| 49 | + | |
54 | 50 | | |
55 | 51 | | |
56 | 52 | | |
| |||
117 | 113 | | |
118 | 114 | | |
119 | 115 | | |
120 | | - | |
| 116 | + | |
121 | 117 | | |
122 | 118 | | |
123 | 119 | | |
| |||
126 | 122 | | |
127 | 123 | | |
128 | 124 | | |
129 | | - | |
130 | 125 | | |
131 | 126 | | |
132 | 127 | | |
| |||
0 commit comments