[[settings]] added application-wise preferences, and commented it out.

Author: soapdog

app.js

@@ -15,7 +15,8 @@ const queryString = require("query-string")
 const { startDefaultPatchfoxServer } = require("./server/server.js")
 const {
   preferencesFileExists,
-  getDefaultIdentity
+  getDefaultIdentity,
+  getPref
 } = require("./ui/core/kernel/prefs.js")
 
 let windows = new Set()
@@ -47,6 +48,7 @@ const createApplicationWindow = (patchfoxEvent = {}, windowState = false) => {
       width: 800,
       height: 800,
       show: false,
+      skipTaskbar: getPref("skipTaskbar", false),
       webPreferences: {
         nodeIntegration: true,
         contextIsolation: false,
@@ -57,6 +59,7 @@ const createApplicationWindow = (patchfoxEvent = {}, windowState = false) => {
       x: windowState.x,
       y: windowState.y,
       show: false,
+      skipTaskbar: getPref("skipTaskbar", false),
       width: windowState.width,
       height: windowState.height,
       webPreferences: {

ui/core/kernel/prefs.js

@@ -79,18 +79,18 @@ const loadSavedData = async () => {
   }
 }
 
-const getPref = (key, defaultValue) => {
+const getPref = (key, defaultValue, namespace = "preferences") => {
   if (!savedData.hasOwnProperty("preferences")) {
-    // maybe not loaded...
-    // this happens when using the first time setup
+    // maybe not loaded. Preferences should always be present. It is added
+    // by the first-time setup.
     if (preferencesFileExists()) {
       savedData = TOML.parse(fs.readFileSync(prefsFile))
     }
   }
 
-  if (savedData.preferences) {
-    if (savedData.preferences.hasOwnProperty(key)) {
-      return savedData.preferences[key]
+  if (savedData[namespace]) {
+    if (savedData[namespace].hasOwnProperty(key)) {
+      return savedData[namespace][key]
     }
   }
   return defaultValue
@@ -134,9 +134,9 @@ const removeIdentity = (key) => {
 }
 
 
-const setPref = (key, value) => {
-  savedData.preferences = savedData.preferences || {}
-  savedData.preferences[key] = value
+const setPref = (key, value, namespace = "preferences") => {
+  savedData[namespace] = savedData[namespace] || {}
+  savedData[namespace][key] = value
 
   writePreferencesFile()
 }

ui/packages/settings/ApplicationPreferences.js

@@ -0,0 +1,103 @@
+/**
+ * I had some ideas for application-wide preferences, but I don't think they're
+ * more important than some missing features I need to implement right away. So,
+ * I'm gonna leave this file here and comment out the menu entry from `SettingsView.js`
+ * so that user's are not confusing.
+ */
+
+const m = require("mithril")
+const { getPref, setPref, setMessageTypeVisibility, getVisibilityForMessageType } = patchfox
+const _ = require("lodash")
+
+const quickAccessBlurb = `
+Select which features should show on the quick-access menu at the top of Patchfox window.
+`
+
+const ApplicationPreferences = {
+  oninit: vnode => {},
+  view: vnode => {
+    let skipTaskbar = getPref("skipTaskbar", false)
+
+    let setShowOnTaskbar = ev => {
+      let skip = ev.target.checked
+      setPref("skipTaskbar", skip)
+    }
+
+    const makeOptions = options => {
+      return options.map(o =>
+        m(
+          "option",
+          {
+            class: o.class ?? "",
+            value: o.value,
+          },
+          o.label
+        )
+      )
+    }
+
+    const makeFormControl = (label, input, inside = false) => {
+      if (inside) {
+        return m(".form-control.w-full", [m("label.label", m("span.label-text", label), input)])
+      } else {
+        return m(".form-control.w-full", [m("label.label", m("span.label-text", label)), input])
+      }
+    }
+
+    const makeSelect = (onchange, label, options) => {
+      return makeFormControl(
+        label,
+        m(
+          "select.select.selectr-bordered.w-full.max-w-ws",
+          {
+            onchange,
+          },
+          makeOptions(options)
+        )
+      )
+    }
+
+    const makeInput = (onchange, label, type = "text", value = "") => {
+      return makeFormControl(
+        label,
+        m("input.input.input-bordered", {
+          value,
+          type,
+          onchange,
+        })
+      )
+    }
+
+    const makeCheckbox = (onchange, checked = true) => {
+      return m("input.checkbox.toggle", {
+        onchange,
+        checked,
+        type: "checkbox",
+      })
+    }
+
+
+    const makeRadio = (onchange, name, checked = false) => {
+      return m("input.radio", {
+        onchange,
+        name,
+        checked,
+        type: "radio",
+      })
+    }
+
+    const makeToggle = (onchange, label, checked) => {
+      return makeFormControl(label, makeCheckbox(onchange, checked), true)
+    }
+
+
+
+    return [
+      m("h1.uppercase.font-medium.text-xl.mb-4", "Application Preferences"),
+      makeToggle(setShowOnTaskbar, "Hide from taskbar", skipTaskbar),
+      m("p.prose", m.trust(ssb.markdown(quickAccessBlurb)))
+    ]
+  },
+}
+
+module.exports = ApplicationPreferences

ui/packages/settings/DisplayPreferences.js

@@ -50,7 +50,7 @@ const DisplayPreferences = {
       return makeFormControl(
         label,
         m(
-          "select.select.selectr-bordered.w-full.max-w-ws",
+          "select.select.select-bordered.w-full.max-w-ws",
           {
             onchange,
           },

ui/packages/settings/SettingsView.js

@@ -1,17 +1,22 @@
 const m = require("mithril")
 const Spinner = require("../../core/components/Spinner.js")
 const DisplayPreferences = require("./DisplayPreferences.js")
+const ApplicationPreferences = require("./ApplicationPreferences.js")
 const AboutView = require("./AboutView.js")
 
 const menu = {
   "about": {
     label: "About Patchfox",
     panel: AboutView
   },
+  // "application": {
+  //   label: "Application Preferences",
+  //   panel: ApplicationPreferences
+  // },
   "display": {
     label: "Display Preferences",
     panel: DisplayPreferences
-  }
+  },
 }