Skip to content

Commit 70a09c1

Browse files
NO-SNOW: Fix tests
1 parent 0bd6084 commit 70a09c1

File tree

10 files changed

+10
-1
lines changed

10 files changed

+10
-1
lines changed

setup.cfg

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ development =
9696
pytest-xdist
9797
pytzdata
9898
responses
99+
pytest-asyncio
99100
pandas =
100101
pandas>=2.1.2,<3.0.0
101102
pyarrow

src/snowflake/connector/aio/_connection.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1037,6 +1037,7 @@ async def connect(self, **kwargs) -> None:
10371037
else:
10381038
self.__config(**self._conn_parameters)
10391039

1040+
self._crl_config: CRLConfig = CRLConfig.from_connection(self)
10401041
self._http_config: AioHttpConfig = AioHttpConfig(
10411042
connector_factory=SnowflakeSSLConnectorFactory(),
10421043
use_pooling=not self.disable_request_pooling,

src/snowflake/connector/aio/_session_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ async def connect(
8686
)
8787
if (
8888
FEATURE_CRL_CONFIG.cert_revocation_check_mode
89-
!= CertRevocationCheckMode.ENABLED
89+
!= CertRevocationCheckMode.DISABLED
9090
):
9191
self.validate_crl(protocol, req)
9292
logger.debug(

src/snowflake/connector/aio/auth/_auth.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ async def authenticate(
9999
self._rest._connection._internal_application_name,
100100
self._rest._connection._internal_application_version,
101101
self._rest._connection._ocsp_mode(),
102+
self._rest._connection.cert_revocation_check_mode,
102103
self._rest._connection._login_timeout,
103104
self._rest._connection._network_timeout,
104105
self._rest._connection._socket_timeout,

src/snowflake/connector/aio/auth/_okta.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ async def _step1(
121121
conn._internal_application_name,
122122
conn._internal_application_version,
123123
conn._ocsp_mode(),
124+
conn.cert_revocation_check_mode,
124125
conn.login_timeout,
125126
conn.network_timeout,
126127
conn.socket_timeout,

src/snowflake/connector/aio/auth/_webbrowser.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,7 @@ async def _get_sso_url(
377377
conn._internal_application_name,
378378
conn._internal_application_version,
379379
conn._ocsp_mode(),
380+
conn.cert_revocation_check_mode,
380381
conn.login_timeout,
381382
conn.network_timeout,
382383
conn.socket_timeout,

test/unit/aio/test_auth_async.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ def _init_rest(application, post_requset):
2525
connection = mock_connection()
2626
connection.errorhandler = Mock(return_value=None)
2727
connection._ocsp_mode = Mock(return_value=OCSPMode.FAIL_OPEN)
28+
connection.cert_revocation_check_mode = "TEST_CRL_MODE"
2829
type(connection).application = PropertyMock(return_value=application)
2930
type(connection)._internal_application_name = PropertyMock(return_value=CLIENT_NAME)
3031
type(connection)._internal_application_version = PropertyMock(

test/unit/aio/test_auth_keypair_async.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ def _init_rest(application, post_requset):
165165
connection = mock_connection()
166166
connection.errorhandler = Mock(return_value=None)
167167
connection._ocsp_mode = Mock(return_value=OCSPMode.FAIL_OPEN)
168+
connection.cert_revocation_check_mode = "TEST_CRL_MODE"
168169
type(connection).application = PropertyMock(return_value=application)
169170
type(connection)._internal_application_name = PropertyMock(return_value=CLIENT_NAME)
170171
type(connection)._internal_application_version = PropertyMock(

test/unit/aio/test_auth_okta_async.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,7 @@ async def post_request(url, headers, body, **kwargs):
361361
connection = mock_connection(disable_saml_url_check=disable_saml_url_check)
362362
connection.errorhandler = Mock(return_value=None)
363363
connection._ocsp_mode = Mock(return_value=OCSPMode.FAIL_OPEN)
364+
connection.cert_revocation_check_mode = "TEST_CRL_MODE"
364365
type(connection).application = PropertyMock(return_value=CLIENT_NAME)
365366
type(connection)._internal_application_name = PropertyMock(return_value=CLIENT_NAME)
366367
type(connection)._internal_application_version = PropertyMock(

test/unit/aio/test_auth_webbrowser_async.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,7 @@ async def post_request(url, headers, body, **kwargs):
414414
connection = mock_connection(socket_timeout=socket_timeout)
415415
connection.errorhandler = Mock(return_value=None)
416416
connection._ocsp_mode = Mock(return_value=OCSPMode.FAIL_OPEN)
417+
connection.cert_revocation_check_mode = "TEST_CRL_MODE"
417418
connection._disable_console_login = disable_console_login
418419
type(connection).application = PropertyMock(return_value=CLIENT_NAME)
419420
type(connection)._internal_application_name = PropertyMock(return_value=CLIENT_NAME)

0 commit comments

Comments
 (0)