fix(bbr): clippy warnings

Author: Jadon-Chan

src/socket/tcp.rs

@@ -197,6 +197,7 @@ impl RttEstimator {
         Duration::from_millis(self.rto as _)
     }
 
+    #[cfg(feature = "socket-tcp-bbr")]
     pub(super) fn min_rtt(&self) -> Duration {
         Duration::from_millis(self.srtt as _)
     }

src/socket/tcp/congestion.rs

@@ -43,6 +43,7 @@ pub(super) trait Controller {
 
 #[derive(Debug)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
+#[allow(clippy::large_enum_variant)]
 pub(super) enum AnyController {
     None(no_control::NoControl),
 

src/socket/tcp/congestion/bbr/bw_estimation.rs

@@ -59,31 +59,29 @@ impl BandwidthEstimation {
             return;
         }
 
-        let send_rate;
-        if self.sent_time.unwrap() > self.prev_sent_time.unwrap() {
-            send_rate = BandwidthEstimation::bw_from_delta(
+        let send_rate = if self.sent_time.unwrap() > self.prev_sent_time.unwrap() {
+            BandwidthEstimation::bw_from_delta(
                 self.total_sent - self.prev_total_sent,
                 self.sent_time.unwrap() - self.prev_sent_time.unwrap(),
             )
-            .unwrap_or(0);
+            .unwrap_or(0)
         } else {
-            send_rate = u64::MAX; // will take the min of send and ack, so this is just a skip
-        }
+            u64::MAX // will take the min of send and ack, so this is just a skip
+        };
 
-        let ack_rate;
-        if let Some(prev_acked_time) = self.prev_acked_time {
+        let ack_rate = if let Some(prev_acked_time) = self.prev_acked_time {
             if self.acked_time.unwrap() > prev_acked_time {
-                ack_rate = BandwidthEstimation::bw_from_delta(
+                BandwidthEstimation::bw_from_delta(
                     self.total_acked - self.prev_total_acked,
                     self.acked_time.unwrap() - prev_acked_time,
                 )
-                .unwrap_or(0);
+                .unwrap_or(0)
             } else {
-                ack_rate = 0;
+                0
             }
         } else {
-            ack_rate = 0;
-        }
+            0
+        };
 
         let bandwidth = send_rate.min(ack_rate);
         if !app_limited && self.max_filter.get() < bandwidth {