Add support php 8.4 - undo pull 220

Author: isublimity

src/Transport/CurlerRequest.php

@@ -106,7 +106,7 @@ class CurlerRequest
     /**
      * @param bool $id
      */
-    public function __construct($id = false, $handle = null)
+    public function __construct($id = false)
     {
         $this->id = $id;
 
@@ -127,7 +127,23 @@ public function __construct($id = false, $handle = null)
             CURLOPT_RETURNTRANSFER => TRUE,
             CURLOPT_USERAGENT => 'smi2/PHPClickHouse/client',
         );
-        $this->handle = $handle;
+    }
+
+    /**
+     *
+     */
+    public function __destruct()
+    {
+        $this->close();
+    }
+
+
+    public function close()
+    {
+        if ($this->handle) {
+            curl_close($this->handle);
+        }
+        $this->handle = null;
     }
 
     /**
@@ -358,7 +374,10 @@ public function isPersistent()
      */
     public function keepAlive(int $sec = 60)
     {
-        $this->headers['Connection'] = 'keep-alive';
+        $this->options[CURLOPT_FORBID_REUSE] = TRUE;
+        $this->headers['Connection'] = 'Keep-Alive';
+        $this->headers['Keep-Alive'] = $sec;
+
         return $this;
     }
 

src/Transport/CurlerRolling.php

@@ -239,16 +239,21 @@ public function getRunningRequests()
 
     /**
      * @param CurlerRequest $request
+     * @param bool $auto_close
      * @return mixed
      * @throws TransportException
      */
-    public function execOne(CurlerRequest $request)
+    public function execOne(CurlerRequest $request, $auto_close = false)
     {
         $h = $request->handle();
         curl_exec($h);
 
         $request->setResponse($this->makeResponse($h));
 
+        if ($auto_close) {
+            $request->close();
+        }
+
         return $request->response()->http_code();
     }
 

src/Transport/Http.php

@@ -122,7 +122,6 @@ public function __construct($host, $port, $username, $password, $authMethod = nu
         $this->_settings = new Settings();
 
         $this->setCurler();
-        $this->setHandle();
     }
 
 
@@ -242,7 +241,7 @@ private function getUrl($params = []): string
      */
     private function newRequest($extendinfo): CurlerRequest
     {
-        $new = new CurlerRequest(false, $this->handle);
+        $new = new CurlerRequest();
 
         switch ($this->_authMethod) {
             case self::AUTH_METHOD_QUERY_STRING:
@@ -577,7 +576,7 @@ public function getRequestWrite(Query $query): CurlerRequest
      */
     public function ping(): bool
     {
-        $request = new CurlerRequest(false, $this->handle);
+        $request = new CurlerRequest();
         $request->url($this->getUri())->verbose(false)->GET()->connectTimeOut($this->getConnectTimeOut());
         $this->_curler->execOne($request);
 
@@ -765,7 +764,7 @@ private function streaming(Stream $streamRW, CurlerRequest $request): Statement
             }
 
 
-            $this->_curler->execOne($request);
+            $this->_curler->execOne($request, true);
             $response = new Statement($request);
             if ($response->isError()) {
                 $response->error();
@@ -808,17 +807,4 @@ public function streamWrite(Stream $streamWrite, $sql, $bindings = []): Statemen
         $request = $this->writeStreamData($sql);
         return $this->streaming($streamWrite, $request);
     }
-
-    public function __destruct()
-    {
-        if ($this->handle) {
-            curl_close($this->handle);
-        }
-    }
-
-    public function setHandle()
-    {
-        $this->handle = curl_init();
-    }
-
 }

src/Transport/StreamInsert.php

@@ -61,7 +61,7 @@ public function insert($callback)
             //
             $this->request->header('Transfer-Encoding', 'chunked');
             $this->request->setReadFunction($callback);
-            $this->curlerRolling->execOne($this->request);
+            $this->curlerRolling->execOne($this->request, true);
             $statement = new Statement($this->request);
             $statement->error();
             return $statement;

tests/docker-compose.yaml

@@ -6,7 +6,7 @@ services:
         hostname: clickhouse
         container_name: clickhouse
         ports:
-        - 9000:9000
+        - 19000:9000
         - 8123:8123
         sysctls:
             net.core.somaxconn: 1024