check for target framework to warn unresolved assemblies

Author: smdn

src/Smdn.Reflection.ReverseGenerating.ListApi.Core/Smdn.Reflection.ReverseGenerating.ListApi/PackageDependencyAssemblyResolver.cs

@@ -36,12 +36,12 @@ internal sealed class PackageDependencyAssemblyResolver {
     return reader.Read(stream);
   }
 
-  private readonly DependencyContext? dependencyContext;
+  public DependencyContext? DependencyContext { get; }
   private readonly ILogger? logger;
 
   public PackageDependencyAssemblyResolver(string componentAssemblyPath, ILogger? logger = null)
   {
-    this.dependencyContext = LoadDependencyContextIfDepsJsonExist(componentAssemblyPath, logger);
+    this.DependencyContext = LoadDependencyContextIfDepsJsonExist(componentAssemblyPath, logger);
     this.logger = logger;
   }
 
@@ -51,12 +51,12 @@ public PackageDependencyAssemblyResolver(string componentAssemblyPath, ILogger?
   {
     logger?.LogTrace("attempting to resolve package dependency assembly '{AssemblyName}'", name);
 
-    if (dependencyContext is null) {
+    if (DependencyContext is null) {
       logger?.LogDebug("could not resolve package dependency '{AssemblyName}'", name);
       return null;
     }
 
-    var runtimeLibrary = dependencyContext
+    var runtimeLibrary = DependencyContext
       .RuntimeLibraries
       .FirstOrDefault(
         runtimeLib => runtimeLib.Name.Equals(name.Name, StringComparison.OrdinalIgnoreCase)

src/Smdn.Reflection.ReverseGenerating.ListApi.Core/Smdn.Reflection.ReverseGenerating.ListApi/PathAssemblyDependencyResolver.cs

@@ -47,7 +47,7 @@ public PathAssemblyDependencyResolver(string componentAssemblyPath, ILogger? log
     assm = packageDependencyResolver.Resolve(assemblyName, context.LoadFromAssemblyPath);
 
     if (assm is null)
-      RuntimeAssemblyName.WarnNotToBeAbleToResolve(logger, assemblyName);
+      RuntimeAssemblyName.WarnNotToBeAbleToResolve(logger, assemblyName, packageDependencyResolver.DependencyContext);
 
     return assm;
   }

src/Smdn.Reflection.ReverseGenerating.ListApi.Core/Smdn.Reflection.ReverseGenerating.ListApi/RuntimeAssemblyName.cs

@@ -8,27 +8,31 @@
 #endif
 using System.Reflection;
 
+using Microsoft.Extensions.DependencyModel;
 using Microsoft.Extensions.Logging;
 
 namespace Smdn.Reflection.ReverseGenerating.ListApi;
 
 internal static class RuntimeAssemblyName {
-  public static void WarnNotToBeAbleToResolve(ILogger? logger, AssemblyName name)
+  public static void WarnNotToBeAbleToResolve(ILogger? logger, AssemblyName name, DependencyContext? depContext)
   {
-    if (ShouldWarnIfNotToBeAbleToResolve(name))
+    if (ShouldWarnIfNotToBeAbleToResolve(name, depContext))
       logger?.LogWarning("could not resolve assembly '{AssemblyName}'", name);
     else
       logger?.LogDebug("could not resolve assembly '{AssemblyName}'", name);
   }
 
-  private static bool ShouldWarnIfNotToBeAbleToResolve(AssemblyName name)
+  private static bool ShouldWarnIfNotToBeAbleToResolve(AssemblyName name, DependencyContext? depContext)
   {
     const bool shouldNotWarn = false;
     const bool shouldWarn = true;
 
     if (name.Name is null)
       return shouldWarn;
 
+    if (depContext is null)
+      return shouldNotWarn; // target framework may be .NET Framework
+
     var publicKeyTokenBytes = name.GetPublicKeyToken();
     var publicKeyTokenString = publicKeyTokenBytes is null
       ? null
@@ -41,28 +45,47 @@ private static bool ShouldWarnIfNotToBeAbleToResolve(AssemblyName name)
     // ref: https://github.com/dotnet/source-build-reference-packages/blob/main/src/referencePackageSourceGenerator/Tasks/GenerateProjects.cs
     const string PublicKeyTokenMicrosoft = "b03f5f7f11d50a3a";
     const string PublicKeyTokenDotnetOpenSource = "cc7b13ffcd2ddd51";
+#if false
     const string PublicKeyTokenEcma = "b77a5c561934e089";
+#endif
 
-    if (string.Equals(name.Name, "mscorlib", StringComparison.Ordinal)) {
-      if (string.Equals(publicKeyTokenString, PublicKeyTokenEcma, StringComparison.OrdinalIgnoreCase))
-        return shouldNotWarn;
-    }
-
-    if (string.Equals(name.Name, "netstandard", StringComparison.Ordinal)) {
-      if (string.Equals(publicKeyTokenString, PublicKeyTokenDotnetOpenSource, StringComparison.OrdinalIgnoreCase))
-        return shouldNotWarn;
-    }
+    var isTargetNetStandard = depContext.Target.Framework.StartsWith(".NETStandard,", StringComparison.Ordinal);
 
-    if (string.Equals(name.Name, "System", StringComparison.Ordinal) || name.Name.StartsWith("System.", StringComparison.Ordinal)) {
+    if (isTargetNetStandard) {
       if (
-        string.Equals(publicKeyTokenString, PublicKeyTokenMicrosoft, StringComparison.OrdinalIgnoreCase) ||
-        string.Equals(publicKeyTokenString, PublicKeyTokenEcma, StringComparison.OrdinalIgnoreCase) ||
+        string.Equals(name.Name, "netstandard", StringComparison.Ordinal) &&
         string.Equals(publicKeyTokenString, PublicKeyTokenDotnetOpenSource, StringComparison.OrdinalIgnoreCase)
       ) {
         return shouldNotWarn;
       }
     }
 
+    var isNameStartsWithOrEqualToSystem =
+      string.Equals(name.Name, "System", StringComparison.Ordinal) ||
+      name.Name.StartsWith("System.", StringComparison.Ordinal);
+
+    if (isNameStartsWithOrEqualToSystem) {
+      var isTargetNetCore = depContext.Target.Framework.StartsWith(".NETCoreApp,", StringComparison.Ordinal);
+
+      if (isTargetNetCore) {
+        if (
+          string.Equals(publicKeyTokenString, PublicKeyTokenDotnetOpenSource, StringComparison.OrdinalIgnoreCase) ||
+          string.Equals(publicKeyTokenString, PublicKeyTokenMicrosoft, StringComparison.OrdinalIgnoreCase)
+        ) {
+          return shouldNotWarn;
+        }
+      }
+
+      if (isTargetNetStandard) {
+        if (
+          string.Equals(publicKeyTokenString, PublicKeyTokenDotnetOpenSource, StringComparison.OrdinalIgnoreCase) ||
+          string.Equals(publicKeyTokenString, PublicKeyTokenMicrosoft, StringComparison.OrdinalIgnoreCase)
+        ) {
+          return shouldNotWarn;
+        }
+      }
+    }
+
     return shouldWarn;
   }
 }

src/Smdn.Reflection.ReverseGenerating.ListApi.Core/Smdn.Reflection.ReverseGenerating.ListApi/UnloadableAssemblyLoadContext.cs

@@ -40,7 +40,7 @@ public UnloadableAssemblyLoadContext(string componentAssemblyPath, ILogger? logg
     var assm = packageDependencyResolver.Resolve(name, this.LoadFromAssemblyPath);
 
     if (assm is null)
-      RuntimeAssemblyName.WarnNotToBeAbleToResolve(logger, name);
+      RuntimeAssemblyName.WarnNotToBeAbleToResolve(logger, name, packageDependencyResolver.DependencyContext);
 
     return assm;
   }