use constraint-based model with Assert.That instead of classic assertions (NUnit.Analyzers NUnit20XX)

Author: smdn

tests/Smdn.Reflection.ReverseGenerating.ListApi.Core/Smdn.Reflection.ReverseGenerating.ListApi/ApiListWriter.cs

@@ -234,7 +234,7 @@ string[] expectedUsingDirectives
       .ReadAllLines()
       .Where(static line => line.StartsWith("using ", StringComparison.Ordinal));
 
-    CollectionAssert.AreEqual(usingDirectives, expectedUsingDirectives);
+    Assert.That(expectedUsingDirectives, Is.EqualTo(usingDirectives).AsCollection);
   }
 
   private static System.Collections.IEnumerable YieldTestCases_WriteExportedTypes_ReferencingNamespaces_NewLine()
@@ -287,10 +287,7 @@ string expectedOutput
         new StringReader(WriteApiListFromSourceCode(sourceCode, options)).ReadAllLines()
       );
 
-    Assert.AreEqual(
-      expectedOutput.Replace("\r\n", "\n").Replace("\r", "\n").TrimEnd(),
-      output.TrimEnd()
-    );
+    Assert.That(output.TrimEnd(), Is.EqualTo(expectedOutput.Replace("\r\n", "\n").Replace("\r", "\n").TrimEnd()));
   }
 
 #if SYSTEM_REFLECTION_NULLABILITYINFOCONTEXT
@@ -372,10 +369,7 @@ string expectedOutput
         new StringReader(WriteApiListFromSourceCode(sourceCode, options)).ReadAllLines()
       );
 
-    Assert.AreEqual(
-      expectedOutput.Replace("\r\n", "\n").Replace("\r", "\n").TrimEnd(),
-      output.TrimEnd()
-    );
+    Assert.That(output.TrimEnd(), Is.EqualTo(expectedOutput.Replace("\r\n", "\n").Replace("\r", "\n").TrimEnd()));
   }
 #endif // SYSTEM_REFLECTION_NULLABILITYINFOCONTEXT
 
@@ -443,14 +437,14 @@ string expectedOutput
     options.Writer.WriteReferencedAssemblies = false;
     options.Writer.WriteFooter = false;
 
-    Assert.AreEqual(
-      expectedOutput.Replace("\r\n", "\n").Replace("\r", "\n").TrimEnd(),
+    Assert.That(
       WriteApiListFromSourceCode(
         sourceCode,
         options,
         assemblyName: assemblyName,
         referenceAssemblyFileNames: referenceAssemblyFileNames
-      ).Replace("\r\n", "\n").Replace("\r", "\n").TrimEnd()
+      ).Replace("\r\n", "\n").Replace("\r", "\n").TrimEnd(),
+      Is.EqualTo(expectedOutput.Replace("\r\n", "\n").Replace("\r", "\n").TrimEnd())
     );
   }
 
@@ -501,23 +495,23 @@ string expectedEmbeddedResourcesOutput
     options.Writer.WriteReferencedAssemblies = false;
 
     if (writeEmbeddedResources) {
-      StringAssert.Contains(
-        expectedEmbeddedResourcesOutput.Replace("\r\n", "\n").Replace("\r", "\n").TrimEnd(),
+      Assert.That(
         WriteApiListFromSourceCode(
           csharpSourceCode: "//",
           options,
           manifestResources: manifestResources
-        ).Replace("\r\n", "\n").Replace("\r", "\n").TrimEnd()
+        ).Replace("\r\n", "\n").Replace("\r", "\n").TrimEnd(),
+        Does.Contain(expectedEmbeddedResourcesOutput.Replace("\r\n", "\n").Replace("\r", "\n").TrimEnd())
       );
     }
     else {
-      StringAssert.DoesNotContain(
-        "//   Embedded resources:",
+      Assert.That(
         WriteApiListFromSourceCode(
           csharpSourceCode: "//",
           options,
           manifestResources: null
-        )
+        ),
+        Does.Not.Contain("//   Embedded resources:")
       );
     }
   }
@@ -535,13 +529,13 @@ public void WriteHeader_WriteEmbeddedResources_HasNoEmbeddedResources(
     options.Writer.WriteEmbeddedResources = writeEmbeddedResources;
     options.Writer.WriteReferencedAssemblies = false;
 
-    StringAssert.DoesNotContain(
-      "//   Embedded resources:",
+    Assert.That(
       WriteApiListFromSourceCode(
         csharpSourceCode: "//",
         options,
         manifestResources: null
-      )
+      ),
+      Does.Not.Contain("//   Embedded resources:")
     );
   }
 
@@ -676,23 +670,14 @@ string[] expectedReferencedAssemblies
     var generated = GenerateApiListFrom(assemblyFile, loadIntoReflectionOnlyContext, options);
 
     if (writeReferencedAssemblies) {
-      StringAssert.Contains(
-        "//   Referenced assemblies:",
-        generated
-      );
+      Assert.That(generated, Does.Contain("//   Referenced assemblies:"));
 
       foreach (var expectedReferencedAssembly in expectedReferencedAssemblies) {
-        StringAssert.Contains(
-          $"//     {expectedReferencedAssembly}",
-          generated
-        );
+        Assert.That(generated, Does.Contain($"//     {expectedReferencedAssembly}"));
       }
     }
     else {
-      StringAssert.DoesNotContain(
-        "//   Referenced assemblies:",
-        generated
-      );
+      Assert.That(generated, Does.Not.Contain("//   Referenced assemblies:"));
     }
 
     string GenerateApiListFrom(
@@ -746,12 +731,12 @@ public void WriteFooter(
     var libraryAssemblyName = typeof(ApiListWriter).Assembly.GetName()!;
 
     if (writeFooter) {
-      StringAssert.Contains($"// API list generated by {executingAssemblyName.Name} v{executingAssemblyName.Version}", output);
-      StringAssert.Contains($"// {libraryAssemblyName.Name} v{libraryAssemblyName.Version}", output);
+      Assert.That(output, Does.Contain($"// API list generated by {executingAssemblyName.Name} v{executingAssemblyName.Version}"));
+      Assert.That(output, Does.Contain($"// {libraryAssemblyName.Name} v{libraryAssemblyName.Version}"));
     }
     else {
-      StringAssert.DoesNotContain("// API list generated by", output);
-      StringAssert.DoesNotContain($"// {libraryAssemblyName.Name} v{libraryAssemblyName.Version}", output);
+      Assert.That(output, Does.Not.Contain("// API list generated by"));
+      Assert.That(output, Does.Not.Contain($"// {libraryAssemblyName.Name} v{libraryAssemblyName.Version}"));
     }
   }
 }

tests/Smdn.Reflection.ReverseGenerating.ListApi.Core/Smdn.Reflection.ReverseGenerating.ListApi/AssemblyExtensions.cs

@@ -36,10 +36,10 @@ public void GetAssemblyMetadataAttributeValue()
   {
     var assm = Assembly.GetExecutingAssembly();
 
-    Assert.AreEqual("foo", assm.GetAssemblyMetadataAttributeValue<AssemblyStringMetadataAttribute, string>(), nameof(AssemblyStringMetadataAttribute));
-    Assert.AreEqual(42, assm.GetAssemblyMetadataAttributeValue<AssemblyIntMetadataAttribute, int>(), nameof(AssemblyIntMetadataAttribute));
+    Assert.That(assm.GetAssemblyMetadataAttributeValue<AssemblyStringMetadataAttribute, string>(), Is.EqualTo("foo"), nameof(AssemblyStringMetadataAttribute));
+    Assert.That(assm.GetAssemblyMetadataAttributeValue<AssemblyIntMetadataAttribute, int>(), Is.EqualTo(42), nameof(AssemblyIntMetadataAttribute));
 
-    Assert.IsNotNull(assm.GetAssemblyMetadataAttributeValue<System.Runtime.Versioning.TargetFrameworkAttribute, string>(), nameof(System.Runtime.Versioning.TargetFrameworkAttribute));
-    Assert.IsNotNull(assm.GetAssemblyMetadataAttributeValue<System.Reflection.AssemblyConfigurationAttribute, string>(), nameof(System.Reflection.AssemblyConfigurationAttribute));
+    Assert.That(assm.GetAssemblyMetadataAttributeValue<System.Runtime.Versioning.TargetFrameworkAttribute, string>(), Is.Not.Null, nameof(System.Runtime.Versioning.TargetFrameworkAttribute));
+    Assert.That(assm.GetAssemblyMetadataAttributeValue<System.Reflection.AssemblyConfigurationAttribute, string>(), Is.Not.Null, nameof(System.Reflection.AssemblyConfigurationAttribute));
   }
 }