Lesson 9 Assert Error

[SlothXGreaver]

When I run
hh test --network rinkeby
on my Lottery.staging.test.js file, I get the following output:

 Lottery Unit Tests
    fulfillRandomWords
Setting up test...
Setting up Listener...
Entering Lottery...
Ok, time to wait...
WinnerPicked event fired!
AssertionError: expected '781901563946176163' to equal '791970612949076221'
    at FragmentRunningEvent.<anonymous> (/home/greaver/FullStack/hardhat-smartcontract-lottery-fcc/test/staging/Lottery.staging.test.js:49:38)
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  showDiff: true,
  actual: '781901563946176163',
  expected: '791970612949076221',
  operator: 'strictEqual'
}

After the error, it hangs, until the
mocha: { timeout: 500000, }
setting in my hardhat.config.js file kicks in.

My Lottery.staging.test.js code is the same as Patrick's atm because I wanted to see if it made a difference. It didn't. (mine is below this code commented out - not included here)...:

const { assert, expect } = require("chai");
const { getNamedAccounts, deployments, ethers, network } = require("hardhat");
const {
    developmentChains,
    networkConfig,
} = require("../../helper-hardhat-config");

developmentChains.includes(network.name)
    ? describe.skip
    : describe("Lottery Unit Tests", function () {
          let lottery, LotteryEntranceFee, deployer;

          beforeEach(async function () {
              deployer = (await getNamedAccounts()).deployer;
              lottery = await ethers.getContract("Lottery", deployer);
              lotteryEntranceFee = await lottery.getEntranceFee();
          });

          describe("fulfillRandomWords", function () {
              it("works with live Chainlink Keepers and Chainlink VRF, we get a random winner", async function () {
                  // enter the lottery
                  console.log("Setting up test...");
                  const startingTimeStamp = await lottery.getLatestTimeStamp();
                  const accounts = await ethers.getSigners();

                  console.log("Setting up Listener...");
                  await new Promise(async (resolve, reject) => {
                      // setup listener before we enter the raffle
                      // Just in case the blockchain moves REALLY fast
                      lottery.once("WinnerPicked", async () => {
                          console.log("WinnerPicked event fired!");
                          try {
                              // add our asserts here
                              const recentWinner =
                                  await lottery.getRecentWinner();
                              const lotteryState =
                                  await lottery.getLotteryState();
                              const winnerEndingBalance =
                                  await accounts[0].getBalance();
                              const endingTimeStamp =
                                  await lottery.getLatestTimeStamp();

                              await expect(lottery.getPlayer(0)).to.be.reverted;
                              assert.equal(
                                  recentWinner.toString(),
                                  accounts[0].address
                              );
                              assert.equal(lotteryState, 0);
                              assert.equal(
                                  winnerEndingBalance.toString(),
                                  winnerStartingBalance
                                      .add(lotteryEntranceFee)
                                      .toString()
                              );
                              assert(endingTimeStamp > startingTimeStamp);
                              resolve();
                          } catch (error) {
                              console.log(error);
                              reject(e);
                          }
                      });
                      // Then entering the lottery
                      console.log("Entering Lottery...");
                      await lottery.enterLottery({ value: lotteryEntranceFee });
                      console.log("Ok, time to wait...");
                      const winnerStartingBalance =
                          await accounts[0].getBalance();

                      // and this code WONT complete until our listener has finished listening!
                  });
              });
          });
      });

The failing math code on the assert at Lottery.staging.test.js:49:38, as you can see is:
assert.equal(winnerEndingBalance.toString(), winnerStartingBalance.add(lotteryEntranceFee).toString());

I am thinking the assert is being called before the promise is being returned, but do not know EXACTLY what is wrong.
The code runs and is error free, but the math isn't working out.

The problem is very similar to #399 , I am monitoring that solution as well.
I tried the tx.wait(1) fix suggested in #348, with no luck.
EDIT... and now with #437 joining in, the problem is becoming an issue.

This is my unit test output:

Lottery Unit Tests
    constructor
      ✓ TEST: Lottery gets Initialised Correctly...
    enterLottery
      ✓ TEST: Lottery reverts when the entry amount is not right...
      ✓ TEST: Makes a record of players when they enter...
      ✓ TEST: 'Lottery Entered' event is emitted correctly...
      ✓ TEST: Lottery is closed-off when calculating...
    checkUpkeep
      ✓ TEST: CheckUpkeep returns false upon non-payment...
      ✓ TEST: CheckUpkeep returns false if lottery is closed...
      ✓ TEST: Returns false if enough time hasn't passed...
      ✓ TEST: Returns true if enough time has passed, has players, ETH and is open...
    performUpkeep
      ✓ TEST: PerformUpkeep can only run when checkUpkeep is true...
      ✓ TEST: PerformUpkeep reverts when checkUpkeep is false...
      ✓ TEST: Lottery state updates, emits an event and calls the VRFCoordinator...
    fulfillRandomWords
      ✓ TEST: FulfillRandomWords can only run after PerformUpkeep has run...
Found the Event!...
      ✓ TEST: Lottery winner picked, lottery is reset and winnings are sent...


  14 passing (5s)

My helper-hardhat-config.js (relative to this issue)

const networkConfig = {
    4: {
        name: "rinkeby",
        vrfCoordinatorV2: "0x6168499c0cFfCaCD319c818142124B7A15E857ab",
        entranceFee: ethers.utils.parseEther("0.01"),
        gasLane:
            "0xd89b2bf150e3b9e13446986e571fb9cab24b13cea0a43ea20a6049a85cc807cc",
        subscriptionId: "6594",
        callbackGasLimit: "500000",
        interval: "30",
    },

And my hardhat.config.js

require("@nomiclabs/hardhat-waffle");
require("@nomiclabs/hardhat-etherscan");
require("hardhat-deploy");
require("solidity-coverage");
require("hardhat-gas-reporter");
//require("hardhat-contract-sizer");
require("dotenv").config();

const RINKEBY_RPC_URL = process.env.RINKEBY_RPC_URL;
const RINKEBY_PRIVATE_KEY = process.env.RINKEBY_PRIVATE_KEY;
const COINMARKETCAP_API_KEY = process.env.COINMARKETCAP_API_KEY;
const ETHERSCAN_API_KEY = process.env.ETHERSCAN_API_KEY;
//const HARDHAT_RPC_URL = process.env.HARDHAT_RPC_URL;

module.exports = {
    defaultNetwork: "hardhat",
    networks: {
        hardhat: {
            chainId: 31337,
            blockConfirmations: 1,
        },
        rinkeby: {
            chainId: 4,
            blockConfirmations: 6,
            url: RINKEBY_RPC_URL,
            accounts: [RINKEBY_PRIVATE_KEY],
        },
    },
    etherscan: {
        apiKey: ETHERSCAN_API_KEY,
    },
    gasReporter: {
        enabled: true,
        outputFile: "gas-report.txt",
        noColors: true,
        currency: "USD",
        coinmarketcap: COINMARKETCAP_API_KEY,
    },
    solidity: {
        compilers: [
            {
                version: "0.8.8",
            },
            {
                version: "0.4.24",
            },
        ],
    },
    namedAccounts: {
        deployer: {
            default: 0,
        },
        player: {
            default: 1,
        },
    },
    mocha: {
        timeout: 500000,
    },
};

[SlothXGreaver]

Should the last transaction be enter the lottery? or should it have returned the amount?
The amount the assert differs is the entry fee (.01E) + the gas txn fee 0.0001726225!!

[PatrickAlphaC]

I think we just need to add some waits in here... I'm having a hard time reproducing your issues.

[Equious]

At least you're getting withdrawals, taking a look here, it seems like my withdrawals don't happen as expected? Despite the funds being returned to my wallet?

Very confused.

[PatrickAlphaC]

I updated the git, can you try again with the new code?

[Equious]

On it.

[Equious]

BOOM! Please tell me what was going on!

[SlothXGreaver]

Thank you very much Patrick.

For anyone else monitoring this for answers, my problem was 2-fold. My original code:

                          } catch (error) {
                              console.log(error);
                              reject(error);
                          }
                          console.log("Marker: Entering Lottery...");
                          await lottery.enterLottery({
                              value: lotteryEntranceFee,
                          });
                          console.log("Marker: Waiting Time...");
                          const winnerStartingBalance =
                              await accounts[0].getBalance();
                      });
                  });
              });
          });
      });

Was supposed to look like this:

                          } catch (error) {
                              console.log(error);
                              reject(error);
                          }
                      });
                      console.log("Marker: Entering Lottery...");
                      const tx = await lottery.enterLottery({
                          value: lotteryEntranceFee,
                      });
                      await tx.wait(1);
                      console.log("Marker: Waiting Time...");
                      const winnerStartingBalance =
                          await accounts[0].getBalance();
                  });
              });
          });
      });

Notice the amount of brackets. This put my enterLottery() into the lottery.once("WinnerPicked", async () => { }
This, combined with the absence of await tx.wait(1); had me scratching my head for days!!

But, the main culprit was await tx.wait(1); was left out.

My test results now :

Lottery Staging Tests
    fulfillRandomWords
Marker: Setting up test...
Marker: Setting up Listener...
Marker: Entering Lottery...
Marker: Waiting Time...
Marker: WinnerPicked event...
Marker: getPlayer reverted...
Marker: winner address is correct...
Marker: lotteryState is reinitialised...
Marker: winnings are deposited...
Marker: timestamp has progressed...
      ✓ TEST: We have a Random Winner when using Chainlink Keepers and VRF... (41654451 gas)


  1 passing (5m)

Whooooohoooo!!!!!!!