Lesson 14: testing randomIpfs.test.ts, revertedWith is not working as expected.

[sanjayojha]

So while testing randomIpfs.test.ts I am getting following error

 AssertionError: Expected transaction to be reverted with reason 'NeedMoreETHSent', but it reverted with a custom error

I am not sure what custom error I am getting instead of the set error in my code in RandomIpfsNft.sol file

function requestNft() public payable returns (uint256 requestId) {
    if (msg.value < i_mintFee) {
        revert NeedMoreETHSent(); // I was expecting this
    }
    requestId = i_vrfCoordinator.requestRandomWords(
        i_gasLane,
        i_subscriptionId,
        REQUEST_CONFIRMATIONS,
        i_callbackGasLimit,
        NUM_WORDS
    );
    s_requesIdToSender[requestId] = msg.sender;
    emit NftRequested(requestId, msg.sender);
}

I have defined error NeedMoreETHSent(); at the top of my RandomIpfsNft.sol file.

My test code. I am sending less mint fee so that it revert with error

describe("requestNft", () => {
    it("Reverts if send ETH is less", async () => {
        //const mintFee = await randomIpfsNft.getMintFee();
        const lessmintFee = ethers.utils.parseEther("0.001");

        await expect(
            randomIpfsNft.requestNft({ value: lessmintFee })
        ).to.be.revertedWith("NeedMoreETHSent");
    });
});

What could be the custom error?

@PatrickAlphaC

[anannyenaik]

I do not know what the problem here is, so I could be wrong, but try:

Increase const lessmintFee = ethers.utils.parseEther("0.001");
While also increasing i_mintFee as you want it to revert.
Just make sure it is a substantial amount as I believe 0.001 is a bit less.

[sanjayojha]

0.001 is less than 0.01 (Mint Fee), so my test should pass with the expected reverted error NeedMoreETHSent

[anannyenaik]

Yes, seems pointless but worth trying in case there is some custom error for the min. amount.
mintFee to 10
and the test lessFee to 5

[sanjayojha]

I tried with 0.1 as mint fee and 0.01 as less mint fee and still the test is failing.

[anannyenaik]

If you tried the above one too, then I'm clueless as well. @ali-thegilfoyle Do you know what could be it?

[alymurtazamemon]

@PatrickAlphaC

[sanjayojha]

@ali-thegilfoyle @Krakxn @PatrickAlphaC

So I saw another supported method revertedWithCustomError and its working.

it("Reverts if send ETH is less", async () => {
    const lessmintFee = ethers.utils.parseEther("0.001");

    await expect(
        randomIpfsNft.requestNft({
            value: lessmintFee.toString(),
        })
    ).to.be.revertedWithCustomError(
        randomIpfsNft,
        "NeedMoreETHSent"
    );
});

I wonder why the revertedWith is not working? Due to changes in chai ? Not sure.

[alymurtazamemon]

@sanjayojha Do you have a hardhat version greater than 2.10.0?

[sanjayojha]

@sanjayojha Do you have a hardhat version greater than 2.10.0?

"hardhat": "^2.10.1",
Yes

[alymurtazamemon]

@sanjayojha Ya it is due to the newer versions, I have noticed many have faced this it is not an issue but it is defiantly different from the course video. I personally still worked with older versions till yet in all my projects.

[alymurtazamemon]

You can match hardhat, ethereum-waffle, and @nomiclabs/hardhat-waffle with the course version and can check.

[sanjayojha]

Thanks, that could be the reason. Though I still prefer newer version because it have some good addition. But I will be more careful and will check in this direction.