Comments

Author: mxiao-cll

packages/sources/dxfeed/src/transport/stock-quotes.ts

@@ -1,6 +1,9 @@
+import { makeLogger } from '@chainlink/external-adapter-framework/util'
 import { BaseEndpointTypes } from '../endpoint/stock-quotes'
 import { buildWsTransport } from './ws'
 
+const logger = makeLogger('StockQuotesTransport')
+
 const eventSymbolIndex = 0
 const bidTimeIndex = 4
 const bidPriceIndex = 6
@@ -20,6 +23,7 @@ export const transport = buildWsTransport<BaseEndpointTypes>(
     const data = message[0].data[1]
 
     if (data.length != dataLength) {
+      logger.warn(`${JSON.stringify(data)} is invalid since it doesn't have ${dataLength} fields.`)
       return []
     }
 

packages/sources/dxfeed/test/integration/fixtures.ts

@@ -63,7 +63,7 @@ export const mockWebSocketServer = (URL: string): MockWebsocketServer => {
     },
   ]
 
-  const quoteReponse2 = [
+  const noBidQuoteReponse = [
     {
       data: [
         'Quote',
@@ -72,7 +72,7 @@ export const mockWebSocketServer = (URL: string): MockWebsocketServer => {
       channel: '/service/data',
     },
   ]
-  const quoteReponse3 = [
+  const noAskQuoteReponse = [
     {
       data: [
         'Quote',
@@ -81,7 +81,7 @@ export const mockWebSocketServer = (URL: string): MockWebsocketServer => {
       channel: '/service/data',
     },
   ]
-  const quoteReponse4 = [
+  const invalidQuoteReponse = [
     {
       data: [
         'Quote',
@@ -125,9 +125,9 @@ export const mockWebSocketServer = (URL: string): MockWebsocketServer => {
     )
     socket.on('message', () => {
       socket.send(JSON.stringify(quoteReponse))
-      socket.send(JSON.stringify(quoteReponse2))
-      socket.send(JSON.stringify(quoteReponse3))
-      socket.send(JSON.stringify(quoteReponse4))
+      socket.send(JSON.stringify(noBidQuoteReponse))
+      socket.send(JSON.stringify(noAskQuoteReponse))
+      socket.send(JSON.stringify(invalidQuoteReponse))
       socket.send(JSON.stringify(tradeResponse))
     })
   })