Skip to content

Commit d6ca36e

Browse files
committed
UI: minor performance fix
1 parent ebeaef8 commit d6ca36e

File tree

5 files changed

+21
-13
lines changed

5 files changed

+21
-13
lines changed

src/common/brun.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ void exec_setup_predefined_variables() {
283283
setsysvar_int(SYSVAR_YMAX, os_graf_my - 1);
284284
setsysvar_int(SYSVAR_TRUE, 1);
285285
setsysvar_int(SYSVAR_FALSE, 0);
286-
setsysvar_str(SYSVAR_PWD, dev_getcwd());
286+
setsysvar_str(SYSVAR_CWD, dev_getcwd());
287287
setsysvar_str(SYSVAR_COMMAND, opt_command);
288288

289289
#if defined(_UnixOS)

src/common/file.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -616,7 +616,7 @@ void dev_chdir(const char *dir) {
616616
if (chdir(dir) != 0) {
617617
err_file(errno);
618618
}
619-
setsysvar_str(SYSVAR_PWD, dev_getcwd());
619+
setsysvar_str(SYSVAR_CWD, dev_getcwd());
620620
}
621621

622622
/**

src/common/scan.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3444,9 +3444,9 @@ void comp_init() {
34443444
comp_vartable[comp_var_getID(LCN_SV_CWD)].dolar_sup = 1;
34453445
comp_vartable[comp_var_getID(LCN_SV_HOME)].dolar_sup = 1;
34463446
comp_vartable[comp_var_getID(LCN_SV_COMMAND)].dolar_sup = 1;
3447-
comp_var_getID(LCN_SV_X); // USE keyword
3448-
comp_var_getID(LCN_SV_Y); // USE keyword
3449-
comp_var_getID(LCN_SV_Z); // USE keyword
3447+
comp_var_getID(LCN_SV_X);
3448+
comp_var_getID(LCN_SV_Y);
3449+
comp_var_getID(LCN_SV_Z);
34503450
}
34513451

34523452
/*

src/common/var.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
#define SYSVAR_YMAX 3 /**< system variable, YMAX @ingroup var */
4949
#define SYSVAR_TRUE 4 /**< system variable, TRUE @ingroup var */
5050
#define SYSVAR_FALSE 5 /**< system variable, FALSE @ingroup var */
51-
#define SYSVAR_PWD 6 /**< system variable, PWD$ @ingroup var */
51+
#define SYSVAR_CWD 6 /**< system variable, CWD$ @ingroup var */
5252
#define SYSVAR_HOME 7 /**< system variable, HOME$ @ingroup var */
5353
#define SYSVAR_COMMAND 8 /**< system variable, COMMAND$ @ingroup var */
5454
#define SYSVAR_X 9 /**< system variable, X @ingroup var */

src/ui/graphics.cpp

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,14 @@ void Graphics::drawLine(int startX, int startY, int endX, int endY) {
136136
}
137137
if (startY >= 0 && startY < _drawTarget->_h) {
138138
pixel_t *line = _drawTarget->getLine(startY);
139+
if (x1 < _drawTarget->x()) {
140+
x1 = _drawTarget->x();
141+
}
142+
if (x2 >= _drawTarget->w()) {
143+
x2 = _drawTarget->w() - 1;
144+
}
139145
for (int x = x1; x <= x2; x++) {
140-
if (x >= _drawTarget->x() && x < _drawTarget->w()) {
141-
line[x] = _drawColor;
142-
}
146+
line[x] = _drawColor;
143147
}
144148
}
145149
} else if (startX == endX) {
@@ -157,11 +161,15 @@ void Graphics::drawLine(int startX, int startY, int endX, int endY) {
157161
y2 = _drawTarget->_h - 1;
158162
}
159163
if (startX >= 0 && startX < _drawTarget->_w) {
164+
if (y1 < _drawTarget->y()) {
165+
y1 = _drawTarget->y();
166+
}
167+
if (y2 >= _drawTarget->h()) {
168+
y2 = _drawTarget->h() - 1;
169+
}
160170
for (int y = y1; y <= y2; y++) {
161-
if (y >= _drawTarget->y() && y < _drawTarget->h()) {
162-
pixel_t *line = _drawTarget->getLine(y);
163-
line[startX] = _drawColor;
164-
}
171+
pixel_t *line = _drawTarget->getLine(y);
172+
line[startX] = _drawColor;
165173
}
166174
}
167175
} else if (opt_antialias) {

0 commit comments

Comments
 (0)