ANDROID: fix permission issue with share command

Author: chrisws

ChangeLog

@@ -1,6 +1,7 @@
 2019-08-19 (0.12.15)
-	ANDROID: fix issue with crash on minimise with googleos
-	ANDROID: update to androidx
+	ANDROID: fix issue with crash on minimise with ChromeOS
+	ANDROID: fix permission issue with share command
+	ANDROID: (internal) update to androidx
 
 2019-07-27 (0.12.15)
 	SDL: added -n command line option to run then not pause for back key

src/platform/android/app/build.gradle

@@ -47,6 +47,6 @@ android {
 }
 
 dependencies {
-  implementation 'androidx.core:core:1.0.0'
+  implementation 'androidx.core:core:1.0.2'
   testImplementation 'junit:junit:4.12'
 }

src/platform/android/app/src/main/AndroidManifest.xml

@@ -52,6 +52,15 @@
         <data android:scheme="smallbasic" />
       </intent-filter>
     </activity>
+    <provider
+      android:name="androidx.core.content.FileProvider"
+      android:authorities="net.sourceforge.smallbasic.provider"
+      android:exported="false"
+      android:grantUriPermissions="true">
+      <meta-data
+        android:name="android.support.FILE_PROVIDER_PATHS"
+        android:resource="@xml/file_paths"/>
+    </provider>
   </application>
   <!-- Permissions -->
   <uses-permission android:name="android.permission.INTERNET" />

src/platform/android/app/src/main/java/net/sourceforge/smallbasic/MainActivity.java

@@ -24,9 +24,6 @@
 import android.os.Bundle;
 import android.os.Environment;
 import android.os.Handler;
-import androidx.annotation.NonNull;
-import androidx.core.app.ActivityCompat;
-import androidx.core.content.ContextCompat;
 import android.util.Base64;
 import android.util.DisplayMetrics;
 import android.util.Log;
@@ -46,11 +43,15 @@
 import java.io.ByteArrayOutputStream;
 import java.io.DataInputStream;
 import java.io.File;
+import java.io.FileInputStream;
 import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
 import java.io.FileReader;
 import java.io.FileWriter;
 import java.io.IOException;
+import java.io.InputStream;
 import java.io.InputStreamReader;
+import java.io.OutputStream;
 import java.io.UnsupportedEncodingException;
 import java.net.Inet4Address;
 import java.net.InetAddress;
@@ -72,6 +73,11 @@
 import java.util.concurrent.Semaphore;
 import java.util.zip.GZIPInputStream;
 
+import androidx.annotation.NonNull;
+import androidx.core.app.ActivityCompat;
+import androidx.core.content.ContextCompat;
+import androidx.core.content.FileProvider;
+
 /**
  * Extends NativeActivity to provide interface methods for runtime.cpp
  *
@@ -539,7 +545,8 @@ public void share(final byte[] pathBytes) {
       Intent sendIntent = new Intent();
       sendIntent.setAction(Intent.ACTION_SEND);
       sendIntent.putExtra(Intent.EXTRA_TEXT, buffer);
-      sendIntent.putExtra(Intent.EXTRA_STREAM, Uri.fromFile(file));
+      sendIntent.putExtra(Intent.EXTRA_STREAM, getSharedFile(file));
+      sendIntent.addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION);
       sendIntent.putExtra(Intent.EXTRA_SUBJECT, file.getName());
       sendIntent.setType("text/plain");
       startActivity(Intent.createChooser(sendIntent, "Share"));
@@ -669,6 +676,24 @@ public void run() {
     });
   }
 
+  private void copy(File src, File dst) throws IOException {
+    InputStream in = new FileInputStream(src);
+    try {
+      OutputStream out = new FileOutputStream(dst);
+      try {
+        byte[] buf = new byte[1024];
+        int len;
+        while ((len = in.read(buf)) > 0) {
+          out.write(buf, 0, len);
+        }
+      } finally {
+        out.close();
+      }
+    } finally {
+      in.close();
+    }
+  }
+
   private String execBuffer(final String buffer, final String name, boolean run) throws IOException {
     File outputFile = getApplication().getFileStreamPath(name);
     BufferedWriter output = new BufferedWriter(new FileWriter(outputFile));
@@ -773,6 +798,23 @@ private Map<String, String> getPostData(DataInputStream inputStream, final Strin
     return result;
   }
 
+  private Uri getSharedFile(File file) {
+    Uri result;
+    try {
+      File sharesPath = new File(getExternalFilesDir(null), "shares");
+      if (sharesPath.mkdirs()) {
+        Log.i(TAG, "created folder: " + sharesPath.toString());
+      }
+      File shareFile = new File(sharesPath, file.getName());
+      copy(file, sharesPath);
+      result = FileProvider.getUriForFile(this, "net.sourceforge.smallbasic.provider", shareFile);
+    } catch (Exception e) {
+      result = null;
+      Log.e(TAG, "failed to create shared file", e);
+    }
+    return result;
+  }
+
   private String getString(final byte[] promptBytes) {
     try {
       return new String(promptBytes, CP1252);

src/platform/android/app/src/main/res/xml/file_paths.xml

@@ -0,0 +1,3 @@
+<paths>
+  <external-files-path name="shares" path="shares/" />
+</paths>