ANDROID: avoid check permission race

Author: chrisws

src/platform/android/app/src/main/java/net/sourceforge/smallbasic/MainActivity.java

@@ -22,6 +22,7 @@
 import android.net.Uri;
 import android.os.Bundle;
 import android.os.Environment;
+import android.os.Handler;
 import android.support.v4.app.ActivityCompat;
 import android.support.v4.content.ContextCompat;
 import android.util.Base64;
@@ -186,17 +187,6 @@ public void browseFile(final byte[] pathBytes) {
     }
   }
 
-  public int checkFilePermission() {
-    int result;
-    if (!permitted(Manifest.permission.WRITE_EXTERNAL_STORAGE)) {
-      checkPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE, REQUEST_STORAGE_PERMISSION);
-      result = 1;
-    } else {
-      result = 0;
-    }
-    return result;
-  }
-
   public void clearSoundQueue() {
     Log.i(TAG, "clearSoundQueue");
     for (Sound sound : _sounds) {
@@ -606,6 +596,7 @@ protected void onCreate(Bundle savedInstanceState) {
     super.onCreate(savedInstanceState);
     processIntent();
     processSettings();
+    checkFilePermission();
   }
 
   @Override
@@ -635,6 +626,18 @@ private String buildTokenForm() {
       "<input value=OK name=okay type=submit style='vertical-align:top'></form>";
   }
 
+  private void checkFilePermission() {
+    if (!permitted(Manifest.permission.WRITE_EXTERNAL_STORAGE)) {
+      Runnable handler = new Runnable() {
+        @Override
+        public void run() {
+          checkPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE, REQUEST_STORAGE_PERMISSION);
+        }
+      };
+      new Handler().postDelayed(handler, 250);
+    }
+  }
+
   private void checkPermission(final String permission, final int result) {
     runOnUiThread(new Runnable() {
       @Override

src/platform/android/jni/runtime.cpp

@@ -458,8 +458,6 @@ void Runtime::runShell() {
   _app->activity->callbacks->onContentRectChanged = onContentRectChanged;
   loadConfig();
 
-  getInteger("checkFilePermission");
-
   String ipAddress = getString("getIpAddress");
   if (!ipAddress.empty()) {
     setenv("IP_ADDR", ipAddress.c_str(), 1);