ANDROID: remove requestLegacyExternalStorage

Author: chrisws

src/platform/android/app/build.gradle

@@ -2,15 +2,15 @@ apply plugin: 'com.android.application'
 
 android {
   // app can use the API features included in this API level and lower.
-  compileSdkVersion 29
+  compileSdkVersion 30
 
   // can override some attributes in main/AndroidManifest.xml
   defaultConfig {
     applicationId 'net.sourceforge.smallbasic'
     minSdkVersion 16
-    targetSdkVersion 29
-    versionCode 43
-    versionName "12.21"
+    targetSdkVersion 30
+    versionCode 44
+    versionName "12.22"
     resConfigs "en"
   }
 

src/platform/android/app/src/main/AndroidManifest.xml

@@ -9,7 +9,6 @@
   <application android:label="@string/app_name"
                android:hasCode="true"
                android:hardwareAccelerated="true"
-               android:requestLegacyExternalStorage="true"
                android:usesCleartextTraffic="true"
                android:hasFragileUserData="true"
                android:icon="@drawable/ic_launcher">

src/platform/android/jni/runtime.cpp

@@ -536,15 +536,8 @@ void Runtime::loadConfig() {
     }
     s = settings.get(PATH_KEY);
     if (s) {
-      const char *legacy = getenv("LEGACY_DIR");
-      if (storage != nullptr && legacy != nullptr && strcmp(legacy, s->c_str()) == 0) {
-        // don't restore the legacy folder
-        trace("path = %s", storage);
-        chdir(storage);
-      } else {
-        trace("path = %s", s->c_str());
-        chdir(s->c_str());
-      }
+      trace("path = %s", s->c_str());
+      chdir(s->c_str());
     }
     s = settings.get(MUTE_AUDIO_KEY);
     if (s && s->toInteger() == 1) {