COMMON: Fix square bracket field access issue

Author: chrisws

ChangeLog

@@ -1,4 +1,7 @@
-2021-01-18 (12.21)
+2021-03-21 (12.21)
+	COMMON: Fix square bracket field access issue
+
+2021-02-23 (12.21)
 	COMMON: Fix crash when line length limit exceeded
 
 2021-01-18 (12.21)

samples/distro-examples/tests/array.bas

@@ -313,4 +313,12 @@ next i
 m[1,2,3,4,5,6]=999
 if (999 <> m[1,2,3,4,5,6]) then
   throw "e"
-endif
+endif
+
+REM test that "[0, 0]" in anims[0].framePoses[0, 0].translation is not scanned as a codearray
+dim amims(0 to 1)
+dim j(0 to 1, 0 to 1)
+j[0, 0].translation = [1,2,3]
+k.framePoses = j
+anims << k
+z=anims[0].framePoses[0, 0].translation

src/common/scan.c

@@ -1331,10 +1331,11 @@ void comp_expression(char *expr, byte no_parser) {
       // string
       ptr = bc_store_string(&bc, ptr);
     } else if (*ptr == '[') {
-      // code-defined array
+      // potential code-defined array
       ptr++;
       level++;
-      if (comp_is_code_array(&bc, ptr)) {
+      // can't be a code array if this is already part of a variable
+      if ((bc.size == 0 || bc.ptr[0] != kwTYPE_VAR) && comp_is_code_array(&bc, ptr)) {
         // otherwise treat as array index
         bc_add_fcode(&bc, kwCODEARRAY);
       }