ANDROID: add shortcut option

Author: chrisws

src/platform/android/jni/runtime.cpp

@@ -178,16 +178,7 @@ Runtime::~Runtime() {
 }
 
 void Runtime::addShortcut(const char *path) {
-  JNIEnv *env;
-  _app->activity->vm->AttachCurrentThread(&env, NULL);
-  jclass clazz = env->GetObjectClass(_app->activity->clazz);
-  jstring pathString = env->NewStringUTF(path);
-  jmethodID methodId = env->GetMethodID(clazz, "addShortcut",
-                                        "(Ljava/lang/String;)V");
-  env->CallVoidMethod(_app->activity->clazz, methodId, pathString);
-  env->DeleteLocalRef(clazz);
-  env->DeleteLocalRef(pathString);
-  _app->activity->vm->DetachCurrentThread();
+  setString("addShortcut", path);
 }
 
 void Runtime::alert(const char *title, const char *message) {
@@ -214,8 +205,7 @@ void Runtime::alert(const char *title, bool longDuration) {
   _app->activity->vm->AttachCurrentThread(&env, NULL);
   jstring titleString = env->NewStringUTF(title);
   jclass clazz = env->GetObjectClass(_app->activity->clazz);
-  jmethodID method = env->GetMethodID(clazz, "showToast",
-                                      "(Ljava/lang/String;Z)V");
+  jmethodID method = env->GetMethodID(clazz, "showToast", "(Ljava/lang/String;Z)V");
   env->CallVoidMethod(_app->activity->clazz, method, titleString, longDuration);
   env->DeleteLocalRef(clazz);
   env->DeleteLocalRef(titleString);

src/platform/android/src/net/sourceforge/smallbasic/MainActivity.java

@@ -99,7 +99,6 @@ public void addShortcut(final String path) {
     intent.putExtra("duplicate", false);
     intent.setAction("com.android.launcher.action.INSTALL_SHORTCUT");
     getApplicationContext().sendBroadcast(intent);
-    showToast("The shortcut " + name + " was created and has been placed on your home screen", true);
   }
 
   public int ask(final String title, final String prompt, final boolean cancel) {

src/ui/system.cpp

@@ -871,17 +871,18 @@ void System::showMenu() {
         items->add(new String(buffer));
         _systemMenu[index++] = MENU_EDITMODE;
       }
+#if !defined(_SDL)
+      if (!_mainBas && _activeFile.length() > 0) {
+        items->add(new String("Desktop Shortcut"));
+        _systemMenu[index++] = MENU_SHORTCUT;
+      }
+#endif
       sprintf(buffer, "Audio [%s]", (opt_mute_audio ? "OFF" : "ON"));
       items->add(new String(buffer));
       _systemMenu[index++] = MENU_AUDIO;
 #if defined(_SDL)
       items->add(new String("Back"));
       _systemMenu[index++] = MENU_BACK;
-#else
-      if (!_mainBas && _activeFile.length() > 0) {
-        items->add(new String("Desktop Shortcut"));
-        _systemMenu[index++] = MENU_SHORTCUT;
-      }
 #endif
     }
     optionsBox(items);