COMMON: fixes for RUN/EXEC

Author: chrisws

src/common/system.c

@@ -122,9 +122,16 @@ int dev_run(const char *src, var_t *r, int wait) {
       result = 0;
     }
   } else if (wait) {
-    char *out = shell(src);
-    if (out != NULL) {
-      free(out);
+    STARTUPINFO si;
+    PROCESS_INFORMATION pi;
+    memset(&si, 0, sizeof(STARTUPINFO));
+    si.cb = sizeof(STARTUPINFO);
+    si.dwFlags = STARTF_USESHOWWINDOW;
+    si.wShowWindow = SW_SHOWNORMAL;
+    if (CreateProcess(NULL, (LPSTR)cmd, NULL, NULL, TRUE, NORMAL_PRIORITY_CLASS, NULL, NULL, &si, &pi)) {
+      WaitForSingleObject(pi.hProcess, INFINITE);
+      CloseHandle(pi.hProcess);
+      CloseHandle(pi.hThread);
     } else {
       result = 0;
     }

src/ui/system.cpp

@@ -1033,6 +1033,13 @@ void System::setRestart() {
   _state = kRestartState;
 }
 
+void System::systemLog(const char *buf) {
+  deviceLog("%s", buf);
+  int prevScreen = _output->selectBackScreen(CONSOLE_SCREEN);
+  _output->print(buf);
+  _output->selectBackScreen(prevScreen);
+}
+
 void System::systemPrint(const char *format, ...) {
   va_list args;
 
@@ -1046,12 +1053,7 @@ void System::systemPrint(const char *format, ...) {
     vsnprintf(buf, size + 1, format, args);
     va_end(args);
     buf[size] = '\0';
-
-    deviceLog("%s", buf);
-
-    int prevScreen = _output->selectBackScreen(CONSOLE_SCREEN);
-    _output->print(buf);
-    _output->selectBackScreen(prevScreen);
+    systemLog(buf);
     free(buf);
   }
 }
@@ -1158,7 +1160,7 @@ void osd_write(const char *str) {
 
 void lwrite(const char *str) {
   if (!(str[0] == '\n' && str[1] == '\0') && !g_system->isClosing()) {
-    g_system->systemPrint(str);
+    g_system->systemLog(str);
   }
 }
 

src/ui/system.h

@@ -49,6 +49,7 @@ struct System {
   void setLoadBreak(const char *path);
   void setLoadPath(const char *path);
   void setRunning(bool running);
+  void systemLog(const char *msg);
   void systemPrint(const char *msg, ...);
   AnsiWidget *getOutput() { return _output; }