Remove no longer relevant lastIndex code from replace method #287

slevithan · slevithan · commit d60ff5205a14 · 2020-10-29T20:17:11.000-04:00
diff --git a/src/xregexp.js b/src/xregexp.js
@@ -1545,11 +1545,6 @@ fixed.replace = function(search, replacement) {
                     }
                 }
             }
-            // Update `lastIndex` before calling `replacement`. Fixes IE, Chrome, Firefox, Safari
-            // bug (last tested IE 9, Chrome 17, Firefox 11, Safari 5.1)
-            if (isRegex && search.global) {
-                search.lastIndex = args[args.length - 2] + args[0].length;
-            }
             // ES6 specs the context for replacement functions as `undefined`
             return replacement(...args);
         });

Original file line number	Diff line number	Diff line change
`@@ -1545,11 +1545,6 @@ fixed.replace = function(search, replacement) {`
`1545`	`1545`	`}`
`1546`	`1546`	`}`
`1547`	`1547`	`}`
`1548`		- // Update `lastIndex` before calling `replacement`. Fixes IE, Chrome, Firefox, Safari
`1549`		`- // bug (last tested IE 9, Chrome 17, Firefox 11, Safari 5.1)`
`1550`		`- if (isRegex && search.global) {`
`1551`		`- search.lastIndex = args[args.length - 2] + args[0].length;`
`1552`		`- }`
`1553`	`1548`	// ES6 specs the context for replacement functions as `undefined`
`1554`	`1549`	`return replacement(...args);`
`1555`	`1550`	`});`