BREAKING: Enable namespacing feature by default

Following up on the [change] to use ES2018 constraints on the names of capture groups,
this makes it so that XRegExp `namespacing` feature is enabled by
default, so that named capture group matches will appear on the
`.groups` property of the match object, rather than directly on the
match object, in accordance with the ES2018 spec.

While this is a breaking change, users can restore the old behavior by running:

    XRegExp.uninstall('namespacing')

[change]: #247 (comment)

Author: josephfrazier

src/xregexp.js

@@ -20,7 +20,7 @@ const REGEX_DATA = 'xregexp';
 // Optional features that can be installed and uninstalled
 const features = {
     astral: false,
-    namespacing: false
+    namespacing: true
 };
 // Native methods to use and restore ('native' is an ES3 reserved keyword)
 const nativ = {

tests/.eslintrc.js

@@ -4,7 +4,7 @@ module.exports = {
     },
     "globals": {
         "XRegExp": true,
-        "disableOptInFeatures": true,
+        "resetFeatures": true,
         "REGEX_DATA": true,
         "hasNativeU": true,
         "hasNativeY": true,

tests/helpers/h.js

@@ -4,9 +4,10 @@ if (typeof global === 'undefined') {
     global.XRegExp = require('../../xregexp-all');
 }
 
-// Ensure that all opt-in features are disabled when each spec starts
-global.disableOptInFeatures = function() {
-    XRegExp.uninstall('namespacing astral');
+// Ensure that all features are reset to default when each spec starts
+global.resetFeatures = function() {
+    XRegExp.uninstall('astral');
+    XRegExp.install('namespacing');
 };
 
 // Property name used for extended regex instance data

tests/spec/s-addons-build.js

@@ -1,5 +1,5 @@
 beforeEach(function() {
-    global.disableOptInFeatures();
+    global.resetFeatures();
     global.addToEqualMatchMatcher();
 });
 

tests/spec/s-addons-matchrecursive.js

@@ -1,5 +1,5 @@
 beforeEach(function() {
-    global.disableOptInFeatures();
+    global.resetFeatures();
     global.addToEqualMatchMatcher();
 });
 

tests/spec/s-addons-unicode.js

@@ -1,5 +1,5 @@
 beforeEach(function() {
-    global.disableOptInFeatures();
+    global.resetFeatures();
     global.addToEqualMatchMatcher();
 });
 

tests/spec/s-xregexp-methods.js

@@ -1,5 +1,5 @@
 beforeEach(function() {
-    global.disableOptInFeatures();
+    global.resetFeatures();
     global.addToEqualMatchMatcher();
 });
 
@@ -445,27 +445,27 @@ describe('XRegExp.exec()', function() {
     // for the RegExp.prototype.exec and nonglobal String.prototype.match specs...
 
     it('should include named capture properties on the match array if namespacing is not installed', function() {
+        XRegExp.uninstall('namespacing');
         var match = XRegExp.exec('a', XRegExp('(?<name>a)'));
 
         expect(match.name).toBe('a');
         expect(match[1]).toBe('a');
     });
 
     it('should not include named capture properties on the match array if namespacing is installed', function() {
-        XRegExp.install('namespacing');
         var match = XRegExp.exec('a', XRegExp('(?<name>a)'));
 
         expect(match.name).toBeUndefined();
     });
 
     it('should not include named capture properties on a groups object if namespacing is not installed', function() {
+        XRegExp.uninstall('namespacing');
         var match = XRegExp.exec('a', XRegExp('(?<name>a)'));
 
         expect(match.groups).toBeUndefined();
     });
 
     it('should include named capture properties on a groups object if namespacing is installed', function() {
-        XRegExp.install('namespacing');
         var match = XRegExp.exec('a', XRegExp('(?<name>a)'));
 
         expect(match.groups.name).toBe('a');
@@ -736,7 +736,9 @@ describe('XRegExp.globalize()', function() {
 
 describe('XRegExp.install()', function() {
 
-    // NOTE: All optional features are uninstalled before each spec runs
+    beforeEach(function() {
+        XRegExp.uninstall('namespacing astral');
+    });
 
     var features = ['namespacing', 'astral'];
 
@@ -1100,14 +1102,14 @@ describe('XRegExp.matchChain()', function() {
     });
 
     it('should handle named and numbered backrefs when namespacing is not installed', function() {
+        XRegExp.uninstall('namespacing');
         expect(XRegExp.matchChain('test', [
             {regex: /.(..)/, backref: 1},
             {regex: XRegExp('.(?<n>.)'), backref: 'n'}
         ])).toEqual(['s']);
     });
 
     it('should handle named and numbered backrefs when namespacing is installed', function() {
-        XRegExp.install('namespacing');
         expect(XRegExp.matchChain('test', [
             {regex: /.(..)/, backref: 1},
             {regex: XRegExp('.(?<n>.)'), backref: 'n'}
@@ -1186,14 +1188,14 @@ describe('XRegExp.replace()', function() {
     });
 
     it('should not pass the groups argument to callbacks when namespacing is not installed', function() {
+        XRegExp.uninstall('namespacing');
         var regex = XRegExp('(?s)(?<groupName>.)');
         XRegExp.replace('test', regex, function(match, capture1, pos, str, groups) {
             expect(groups).toBeUndefined();
         });
     });
 
     it('should pass the groups argument to callbacks when namespacing is installed', function() {
-        XRegExp.install('namespacing');
         var regex = XRegExp('(?s)(?<groupName>.)');
         var groupsObject = Object.create(null);
         groupsObject.groupName = 't';
@@ -1203,13 +1205,13 @@ describe('XRegExp.replace()', function() {
     });
 
     it('should allow accessing named backreferences in callbacks as properties of the first argument when namespacing is not installed', function() {
+        XRegExp.uninstall('namespacing');
         expect(XRegExp.replace('abc', XRegExp('(?<name>.).'), function(match) {
             return ':' + match.name + ':';
         })).toBe(':a:c');
     });
 
     it('should not allow accessing named backreferences in callbacks as properties of the first argument when namespacing is installed', function() {
-        XRegExp.install('namespacing');
         expect(XRegExp.replace('abc', XRegExp('(?<name>.).'), function(match) {
             return ':' + match.name + ':';
         })).toBe(':undefined:c');

tests/spec/s-xregexp.js

@@ -1,5 +1,5 @@
 beforeEach(function() {
-    global.disableOptInFeatures();
+    global.resetFeatures();
     global.addToEqualMatchMatcher();
 });
 
@@ -421,14 +421,14 @@ describe('XRegExp()', function() {
             });
 
             it('should throw an exception if reserved words are used as capture names if namespacing is not installed', function() {
+                XRegExp.uninstall('namespacing');
                 // Only these names are reserved
                 ['length', '__proto__'].forEach(function(name) {
                     expect(function() {XRegExp('(?<' + name + '>)');}).toThrowError(SyntaxError);
                 });
             });
 
             it('should not throw an exception if reserved words are used as capture names if namespacing is installed', function() {
-                XRegExp.install('namespacing');
                 ['length', '__proto__'].forEach(function(name) {
                     expect(function() {XRegExp('(?<' + name + '>)');}).not.toThrow();
                 });