prevent broadcasting over eachcol

Author: sl-solution

src/abstractdataset/iteration.jl

@@ -391,14 +391,15 @@ Base.show(dfcs::DatasetColumns;
          summary=summary, eltypes=eltypes, truncate=truncate, kwargs...)
 
 
-
-
 # prevent using broadcasting to mutate columns e.g. in pop!.(eachcol(ds))
-Base.broadcasted(::typeof(pop!), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `pop!` over DatasetColums is reserved."))
-Base.broadcasted(::typeof(popfirst!), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `popfirst!` over DatasetColums is reserved."))
-Base.broadcasted(::typeof(pushfirst!), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `pushfirst!` over DatasetColums is reserved."))
-Base.broadcasted(::typeof(fill!), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `fill!` over DatasetColums is reserved."))
-Base.broadcasted(::typeof(Statistics.median!), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `median!` over DatasetColums is reserved."))
-Base.broadcasted(::typeof(sort!), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `sort!` over DatasetColums is reserved."))
-Base.broadcasted(::typeof(lag!), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `lag!` over DatasetColums is reserved."))
-Base.broadcasted(::typeof(lead!), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `lead!` over DatasetColums is reserved."))
+# TODO customise Base.broadcasted to handle the situation
+for f in filter(x->occursin(r"!$", String(x)), names(Base))
+  @eval Base.broadcasted(::typeof($f), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `$(nameof($f))` over DatasetColums is reserved."))
+end
+for f in filter(x->occursin(r"!$", String(x)), names(Statistics))
+  @eval Base.broadcasted(::typeof($f), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `$(nameof($f))` over DatasetColums is reserved."))
+end
+for f in [:bfill!, :ffill!, :lag!, :lead!]
+  @eval Base.broadcasted(::typeof($f), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `$(nameof($f))` over DatasetColums is reserved."))
+end
+