bug fix

sl-solution · sl-solution · commit 58ad1f8e1f2e · 2021-12-24T10:35:31.000+13:00
diff --git a/src/abstractdataset/abstractdataset.jl b/src/abstractdataset/abstractdataset.jl
@@ -794,7 +794,7 @@ Base.first(ds::AbstractDataset, n::Integer) = ds[1:min(n, nrow(ds)), :]
 
 Get the last row of `ds` as a `DatasetRow`.
 """
-Base.last(ds::AbstractDataset) = ds[nrow(df), :]
+Base.last(ds::AbstractDataset) = ds[nrow(ds), :]
 
 """
     last(ds::AbstractDataset, n::Integer)
diff --git a/src/datasetrow/datasetrow.jl b/src/datasetrow/datasetrow.jl
@@ -503,7 +503,7 @@ function Dataset(dsr::DatasetRow)
 end
 
 Base.push!(ds::Dataset, dsr::DatasetRow, cols::Symbol=:setequal, promote::Bool=(cols in [:union, :subset])) =
-    push!(ds, NamedTuple(dsr), cols, promote)
+    push!(ds, NamedTuple(dsr); cols = cols, promote = promote)
 # @noinline pushhelper!(x, r) = push!(x, x[r])
 #
 # function Base.push!(ds::Dataset, dsr::DatasetRow; cols::Symbol=:setequal,

Original file line number	Diff line number	Diff line change
`@@ -503,7 +503,7 @@ function Dataset(dsr::DatasetRow)`
`503`	`503`	`end`
`504`	`504`
`505`	`505`	`Base.push!(ds::Dataset, dsr::DatasetRow, cols::Symbol=:setequal, promote::Bool=(cols in [:union, :subset])) =`
`506`		`- push!(ds, NamedTuple(dsr), cols, promote)`
	`506`	`+ push!(ds, NamedTuple(dsr); cols = cols, promote = promote)`
`507`	`507`	`# @noinline pushhelper!(x, r) = push!(x, x[r])`
`508`	`508`	`#`
`509`	`509`	`# function Base.push!(ds::Dataset, dsr::DatasetRow; cols::Symbol=:setequal,`