remove old definition of byrow(ds, isequal, cols))

Author: sl-solution

src/byrow/byrow.jl

@@ -44,15 +44,13 @@ function byrow(ds::AbstractDataset, ::typeof(all), cols::MultiColumnIndex = :; b
 end
 byrow(ds::AbstractDataset, ::typeof(all), col::ColumnIndex; by = x->isequal(true, x), threads = nrow(ds)>1000) = byrow(ds, all, [col]; by = by, threads = threads)
 
-byrow(ds::AbstractDataset, ::typeof(isequal), cols::MultiColumnIndex; threads = nrow(ds)>1000) = row_isequal(ds, cols, threads = threads) 
+byrow(ds::AbstractDataset, ::typeof(isequal), cols::MultiColumnIndex; threads = nrow(ds)>1000) = row_isequal(ds, cols, threads = threads)
 byrow(ds::AbstractDataset, ::typeof(findfirst), cols::MultiColumnIndex; by = identity, threads = nrow(ds)> 1000) = row_findfirst(ds, by, cols; threads = threads)
 byrow(ds::AbstractDataset, ::typeof(findlast), cols::MultiColumnIndex; by = identity, threads = nrow(ds)> 1000) = row_findlast(ds, by, cols; threads = threads)
 
 
 byrow(ds::AbstractDataset, ::typeof(coalesce), cols::MultiColumnIndex; threads = nrow(ds)>1000) = threads ? hp_row_coalesce(ds, cols) : row_coalesce(ds, cols)
 
-byrow(ds::AbstractDataset, ::typeof(isequal), cols::MultiColumnIndex; threads = nrow(ds)>1000) = threads ? hp_row_isequal(ds, cols) : row_isequal(ds, cols)
-
 byrow(ds::AbstractDataset, ::typeof(mean), cols::MultiColumnIndex = names(ds, Union{Missing, Number}); by = identity, threads = nrow(ds)>1000) = threads ? hp_row_mean(ds, by, cols) : row_mean(ds, by, cols)
 byrow(ds::AbstractDataset, ::typeof(mean), col::ColumnIndex; by = identity, threads = nrow(ds)>1000) = byrow(ds, mean, [col]; by = by, threads = threads)
 

src/byrow/hp_row_functions.jl

@@ -111,21 +111,6 @@ function hp_row_coalesce(ds::AbstractDataset, cols = names(ds, Union{Missing, Nu
     mapreduce(identity, hp_op_coalesce!, view(_columns(ds),colsidx), init = init0)
 end
 
-function hp_op_isequal!(x,y,x1)
-    Threads.@threads for i in 1:length(x)
-        @inbounds x[i] &= isequal(x1[i], y[i])
-    end
-    x
-end
-function hp_row_isequal(ds::AbstractDataset, cols)
-    colsidx = index(ds)[cols]
-    init0 = ones(Bool, nrow(ds))
-    length(colsidx) == 1 && return init0
-    x1 = _columns(ds)[colsidx[1]]
-    mapreduce(identity, (x, y)->hp_op_isequal!(x, y, x1), view(_columns(ds),view(colsidx, 2:length(colsidx))), init = init0)
-end
-
-
 function hp_row_mean(ds::AbstractDataset, f::Function, cols = names(ds, Union{Missing, Number}))
     hp_row_sum(ds, f, cols) ./ hp_row_count(ds, x -> !ismissing(x), cols)
 end

src/byrow/row_functions.jl

@@ -175,15 +175,6 @@ function row_coalesce(ds::AbstractDataset, cols = names(ds, Union{Missing, Numbe
     mapreduce(identity, _op_for_coalesce!, view(_columns(ds),colsidx), init = init0)
 end
 
-function row_isequal(ds::AbstractDataset, cols)
-    colsidx = index(ds)[cols]
-    init0 = ones(Bool, nrow(ds))
-    _op_for_isequal!(x, y, x1) = x .&= isequal.(x1, y)
-    length(colsidx) == 1 && return init0
-    x1 = _columns(ds)[colsidx[1]]
-    mapreduce(identity, (x, y)->_op_for_isequal!(x, y, x1), view(_columns(ds),view(colsidx, 2:length(colsidx))), init = init0)
-end
-
 function row_mean(ds::AbstractDataset, f::Function, cols = names(ds, Union{Missing, Number}))
     row_sum(ds, f, cols) ./ row_count(ds, x -> !ismissing(x), cols)
 end