Skip to content

Commit 4283dd2

Browse files
committed
Update other.jl
1 parent 7f05647 commit 4283dd2

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/dataset/other.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1058,7 +1058,9 @@ Refer to [`filter`](@ref) for exmaples.
10581058
10591059
See [`byrow`](@ref), [`filter`](@ref), [`delete!`](@ref), [`delete`](@ref)
10601060
"""
1061-
Base.filter!(ds::Dataset, cols::Union{Vector{T}, ColumnIndex, MultiColumnIndex}; type = all, kwargs...) where T <: Union{<:Integer, Symbol, AbstractString} = deleteat!(ds, .!byrow(ds, type, cols; kwargs...))
1061+
_filter!(ds::Dataset, cols::Union{AbstractVector{T}, ColumnIndex, MultiColumnIndex}; type = all, kwargs...) where T <: Union{<:Integer, Symbol, AbstractString} = deleteat!(ds, .!byrow(ds, type, cols; kwargs...))
1062+
Base.filter!(ds::Dataset, cols::AbstractVector; type = all, kwargs...) = _filter!(ds, cols; type = type, kwargs...)
1063+
Base.filter!(ds::Dataset, cols::Union{ColumnIndex, MultiColumnIndex}; type = all, kwargs...) = _filter!(ds, cols; type = type, kwargs...)
10621064

10631065
# filter out `true`s
10641066
"""

0 commit comments

Comments
 (0)