Add eslint

Signed-off-by: Eric Wang <skygragon@gmail.com>

Author: skygragon

.eslintrc.js

@@ -0,0 +1,12 @@
+module.exports = {
+    "extends": "google",
+    "rules": {
+      "key-spacing": [2, { "align": "value" }],
+      "no-eval": 1, // we use it on purpose
+      "no-multi-spaces": [2, { exceptions: { "SwitchCase": true }}],
+      "no-unused-expressions": 1,
+      "no-unused-vars": 1,
+      "quote-props": 1,
+      "require-jsdoc": 0,  // currently we don't need JSDoc
+    }
+};

.travis.yml

@@ -0,0 +1,6 @@
+language: node_js
+node_js:
+  - stable
+install:
+  - npm install -g eslint-cli
+  - npm install

lib/commands/list.js

@@ -1,40 +1,40 @@
-var sprintf = require('sprintf-js').sprintf,
-    _ = require('underscore');
+var _ = require('underscore');
+var sprintf = require('sprintf-js').sprintf;
 
-var core = require('../core'),
-    h = require('../helper');
+var core = require('../core');
+var h = require('../helper');
 
 var cmd = {
   command: 'list [--cached|-c] [--undone|-D]',
-  desc: 'List all problems.',
+  desc:    'List all problems.',
   builder: {
     cached: {
-      alias: 'c',
+      alias:    'c',
       describe: 'List cached problems.'
     },
     undone: {
-      alias: 'D',
+      alias:    'D',
       describe: 'List undone problems.'
     }
   }
 };
 
 cmd.handler = function(argv) {
-  core.getProblems(function(e, problems){
+  core.getProblems(function(e, problems) {
     if (e) return console.log('ERROR:', e);
 
     if (argv.undone) {
-      problems = _.filter(problems, function(x){
-        return x.state != 'ac';
+      problems = _.filter(problems, function(x) {
+        return x.state !== 'ac';
       });
     }
 
-    problems.forEach(function(problem){
+    problems.forEach(function(problem) {
       console.log(sprintf('%s [%3d] %-60s %-6s (%s)',
             h.prettyState(problem.state), problem.id,
             problem.name, problem.level, problem.percent));
     });
   });
-}
+};
 
 module.exports = cmd;

lib/commands/show.js

@@ -1,44 +1,45 @@
-var sprintf = require('sprintf-js').sprintf,
-    _ = require('underscore'),
-    fs = require('fs');
+var _ = require('underscore');
+var fs = require('fs');
 
-var core = require('../core'),
-    config = require('../config'),
-    h = require('../helper');
+var sprintf = require('sprintf-js').sprintf;
+
+var config = require('../config');
+var core = require('../core');
+var h = require('../helper');
 
 var cmd = {
   command: 'show <keyword> [--gen|-g] [--lang|-l]',
-  desc: 'Show problem details.',
+  desc:    'Show problem details.',
   builder: {
     keyword: {
       describe: 'Problem keyword, e.g. name, index, or URI path.'
     },
     gen: {
-      alias: 'g',
-      type: 'boolean',
+      alias:    'g',
+      type:     'boolean',
       describe: 'Generate template source file.'
     },
     lang: {
-      alias: 'l',
-      type: 'string',
-      default: config.LANG,
+      alias:    'l',
+      type:     'string',
+      default:  config.LANG,
       describe: 'Language to use, used with -g.'
     }
   }
 };
 
 cmd.handler = function(argv) {
-
-  core.getProblem(argv.keyword, function(e, problem){
+  core.getProblem(argv.keyword, function(e, problem) {
     if (e) return console.log('ERROR:', e);
 
     var msg = '';
     if (argv.gen) {
-      var template = _.find(problem.templates, function(x){
-        return x.value == argv.lang;
+      var template = _.find(problem.templates, function(x) {
+        return x.value === argv.lang;
       });
       if (!template)
-        return console.log('Failed to generate source file: unknown language', argv.lang);
+        return console.log('Failed to generate source file: ' +
+            'unknown language ' + argv.lang);
 
       var f = problem.key + h.langToExt(argv.lang);
       fs.writeFileSync(f, template.defaultCode);
@@ -48,10 +49,10 @@ cmd.handler = function(argv) {
     console.log(sprintf('[%d] %s\t%s\n', problem.id, problem.name, msg));
     console.log(sprintf('%s\n', problem.link));
     console.log(sprintf('* %s (%s)', problem.level, problem.percent));
-    console.log(sprintf('* Total Accepted: %d', problem.total_ac));
-    console.log(sprintf('* Total Submissions: %d\n', problem.total_submit));
+    console.log(sprintf('* Total Accepted: %d', problem.totalAC));
+    console.log(sprintf('* Total Submissions: %d\n', problem.totalSubmit));
     console.log(problem.desc);
   });
-}
+};
 
 module.exports = cmd;

lib/commands/submit.js

@@ -1,11 +1,11 @@
-var  util = require('util');
+var util = require('util');
 
-var core = require('../core'),
-    h = require('../helper');
+var core = require('../core');
+var h = require('../helper');
 
 var cmd = {
   command: 'submit <filename>',
-  desc: 'Submit solution to leetcode.',
+  desc:    'Submit solution to leetcode.',
   builder: {
     filename: {
       describe: 'Problem source file name.'
@@ -15,21 +15,22 @@ var cmd = {
 
 cmd.handler = function(argv) {
   var keyword = h.getFilename(argv.filename);
-  core.getProblem(keyword, function(e, problem){
+  core.getProblem(keyword, function(e, problem) {
     if (e) return console.log('ERROR:', e);
 
     problem.file = argv.filename;
 
-    core.submitProblem(problem, function(e, results){
+    core.submitProblem(problem, function(e, results) {
       if (e) return console.log('ERROR:', e);
 
       var result = results[0];
-      var ok = (result.total_correct == result.total_testcases) &&
-        (result.status_code == 10);
-      var run_ok = result.run_success;
+      var ok = (result.status_code === 10) &&
+        (result.total_correct === result.total_testcases);
 
-      if (!ok && run_ok) {
-        console.log(util.format('input:\n%s',   result['input']));
+      var runOk = result.run_success;
+
+      if (!ok && runOk) {
+        console.log(util.format('input:\n%s', result.input));
       }
 
       console.log(util.format('    %s %s',
@@ -41,12 +42,14 @@ cmd.handler = function(argv) {
             result.total_testcases,
             result.status_runtime));
 
-      if (!ok && run_ok) {
-        console.log(util.format('    ✘ output:   %s', result['code_output']));
-        console.log(util.format('    ✔ expected: %s', result['expected_output']));
+      if (!ok && runOk) {
+        console.log(util.format(
+              '    ✘ output:   %s', result.code_output));
+        console.log(util.format(
+              '    ✔ expected: %s', result.expected_output));
       }
     });
   });
-}
+};
 
 module.exports = cmd;

lib/commands/test.js

@@ -1,32 +1,36 @@
-var  util = require('util'),
-     _ = require('underscore');
+var _ = require('underscore');
+var util = require('util');
 
-var core = require('../core'),
-    h = require('../helper');
+var core = require('../core');
+var h = require('../helper');
 
 var cmd = {
   command: 'test <filename> [--testcase|-t] [-i]',
-  desc: 'Run test case to leetcode.',
+  desc:    'Run test case to leetcode.',
   builder: {
     filename: {
       describe: 'Problem source file name.'
     },
     testcase: {
-      alias: 't',
-      type: 'string',
+      alias:    't',
+      type:     'string',
       describe: 'Provide test case.'
     },
     i: {
-      type: 'boolean',
+      type:     'boolean',
       describe: 'Provide test case interactively.'
     }
   }
 };
 
 function prettyLine(actual, expected, key) {
   var sym = '✔';
-  if (!actual.run_success) { sym = '✘'; }
-  else if (expected && key != 'status_runtime' && !_.isEqual(actual[key], expected[key])) { sym = '✘'; }
+  if (!actual.run_success) {
+    sym = '✘';
+  } else if (expected && key !== 'status_runtime' &&
+           !_.isEqual(actual[key], expected[key])) {
+    sym = '✘';
+  }
   return util.format('    %s %s: %s', sym, key.split('_').pop(), actual[key]);
 }
 
@@ -37,7 +41,7 @@ cmd.handler = function(argv) {
   }
 
   var keyword = h.getFilename(argv.filename);
-  core.getProblem(keyword, function(e, problem){
+  core.getProblem(keyword, function(e, problem) {
     if (e) return console.log('ERROR:', e);
 
     problem.file = argv.filename;
@@ -46,18 +50,18 @@ cmd.handler = function(argv) {
     console.log('\nInput data:');
     console.log(problem.testcase);
 
-    core.testProblem(problem, function(e, results){
+    core.testProblem(problem, function(e, results) {
       if (e) return console.log('ERROR:', e);
 
-      for (var i=0; i< results.length; ++i) {
+      for (var i = 0; i < results.length; ++i) {
         console.log();
         console.log(results[i].name);
-        console.log(prettyLine(results[i], results[i+1], 'status_runtime'));
-        console.log(prettyLine(results[i], results[i+1], 'code_answer'));
-        console.log(prettyLine(results[i], results[i+1], 'code_output'));
+        console.log(prettyLine(results[i], results[i + 1], 'status_runtime'));
+        console.log(prettyLine(results[i], results[i + 1], 'code_answer'));
+        console.log(prettyLine(results[i], results[i + 1], 'code_output'));
       }
     });
   });
-}
+};
 
 module.exports = cmd;

lib/commands/update.js

@@ -1,13 +1,13 @@
 var cmd = {
   command: 'update [--cached|-c] [--all|-a]',
-  desc: 'Update problems list from leetcode.',
+  desc:    'Update problems list from leetcode.',
   builder: {
     all: {
-      alias: 'a',
+      alias:    'a',
       describe: 'Update all problems. (slow!)'
     },
     cached: {
-      alias: 'c',
+      alias:    'c',
       describe: 'Also update those cached problems.'
     }
   }
@@ -16,6 +16,6 @@ var cmd = {
 cmd.handler = function(argv) {
   // TODO
   console.log(argv);
-}
+};
 
 module.exports = cmd;

lib/commands/user.js

@@ -1,56 +1,56 @@
-var prompt = require('prompt'),
-    util = require('util');
+var prompt = require('prompt');
 
 var core = require('../core');
 
 var cmd = {
   command: 'user [--login|-l] [--logout|-L]',
-  desc: 'Login/logout with leetcode account.',
+  desc:    'Login/logout with leetcode account.',
   builder: {
     login: {
-      alias: 'l',
+      alias:    'l',
       describe: 'Login leetcode.'
     },
     logout: {
-      alias: 'L',
+      alias:    'L',
       describe: 'Logout leetcode.'
     }
   }
 };
 
 cmd.handler = function(argv) {
+  var user = null;
   if (argv.login) {
     // login
     prompt.colors = false;
     prompt.message = '';
     prompt.start();
     prompt.get([
-      { name: 'login', required: true },
-      { name: 'pass', required: true, hidden: true }
-    ], function(e, user){
+      {name: 'login', required: true},
+      {name: 'pass', required: true, hidden: true}
+    ], function(e, user) {
       if (e) return console.log('Login failed:', e);
 
-      core.login(user, function(e, user){
+      core.login(user, function(e, user) {
         if (e) return console.log('Login failed:', e);
 
         console.log('Successfully login as', user.name);
       });
     });
   } else if (argv.logout) {
     // logout
-    var user = core.logout(null);
+    user = core.logout(null);
     if (user)
       console.log('Successfully logout as', user.name);
     else
       console.log('You are not login yet?');
   } else {
     // show current user
-    var user = core.getUser();
+    user = core.getUser();
     if (user)
       console.log('You are now login as', user.name);
     else
       console.log('You are not login yet?');
   }
-}
+};
 
 module.exports = cmd;

lib/config.js

@@ -8,5 +8,5 @@ module.exports = {
   VERIFY_URL:   'https://leetcode.com/submissions/detail/$id/check/',
 
   // but you will want change these
-  LANG:         'cpp' // others: c,csharp,golang,java,javascript,python,ruby,swift
+  LANG: 'cpp' // others: c,csharp,golang,java,javascript,python,ruby,swift
 };