Refactor user login.

* refs #71: prepare for cookie.chrome plugin.

Signed-off-by: Eric Wang <skygragon@gmail.com>

Author: skygragon

lib/plugins/cache.js

@@ -6,7 +6,7 @@ var log = require('../log');
 var Plugin = require('../plugin');
 var session = require('../session');
 
-var plugin = new Plugin(20, 'cache', '', 'Plugin to provide local cache.');
+var plugin = new Plugin(50, 'cache', '', 'Plugin to provide local cache.');
 
 plugin.init = function() {
   Plugin.prototype.init.call(this);

lib/plugins/leetcode.js

@@ -398,23 +398,26 @@ plugin.signin = function(user, cb) {
   });
 };
 
+plugin.getUser = function(user, cb) {
+  plugin.getFavorites(function(e, favorites) {
+    if (e) return cb(e);
+
+    var favorite = _.find(favorites.favorites.private_favorites, function(f) {
+      return f.name === 'Favorite';
+    });
+    user.hash = favorite.id_hash;
+    user.name = favorites.user_name;
+
+    return cb(null, user);
+  });
+};
+
 plugin.login = function(user, cb) {
   log.debug('running leetcode.login');
   plugin.signin(user, function(e, user) {
     if (e) return cb(e);
     session.saveUser(user);
-
-    plugin.getFavorites(function(e, favorites) {
-      if (e) return cb(e);
-
-      // TODO: pick other useful values from favorites
-      var favorite = _.find(favorites.favorites.private_favorites, function(f) {
-        return f.name === 'Favorite';
-      });
-      user.hash = favorite.id_hash;
-
-      return cb(null, user);
-    });
+    plugin.getUser(user, cb);
   });
 };
 

test/plugins/test_leetcode.js

@@ -59,7 +59,12 @@ describe('plugin:leetcode', function() {
 
       nock('https://leetcode.com')
         .get('/list/api/questions')
-        .reply(200, JSON.stringify({favorites: {private_favorites: [{id_hash: 'abcdef', name: 'Favorite'}]}}));
+        .reply(200, JSON.stringify({
+          user_name: 'Eric',
+          favorites: {
+            private_favorites: [{id_hash: 'abcdef', name: 'Favorite'}]
+          }
+        }));
 
       plugin.login({}, function(e, user) {
         assert.equal(e, null);