Skip to content

Commit 20f3979

Browse files
skygragonskygragon
committed
Use const, let, 2nd round.
Signed-off-by: Eric Wang <skygragon@gmail.com>
1 parent b8d84e6 commit 20f3979

File tree

12 files changed

+147
-147
lines changed

12 files changed

+147
-147
lines changed

‎test/plugins/test_cache.js‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,29 @@
11
'use strict';
2-
var execSync = require('child_process').execSync;
3-
var fs = require('fs');
2+
const execSync = require('child_process').execSync;
3+
const fs = require('fs');
44

5-
var _ = require('underscore');
6-
var assert = require('chai').assert;
7-
var rewire = require('rewire');
5+
const _ = require('underscore');
6+
const assert = require('chai').assert;
7+
const rewire = require('rewire');
88

9-
var log = require('../../lib/log');
10-
var config = require('../../lib/config');
9+
const log = require('../../lib/log');
10+
const config = require('../../lib/config');
1111

12-
var cache = rewire('../../lib/cache');
13-
var h = rewire('../../lib/helper');
14-
var session = rewire('../../lib/session');
15-
var plugin = rewire('../../lib/plugins/cache');
12+
const cache = rewire('../../lib/cache');
13+
const h = rewire('../../lib/helper');
14+
const session = rewire('../../lib/session');
15+
const plugin = rewire('../../lib/plugins/cache');
1616

17-
var HOME = './tmp';
17+
const HOME = './tmp';
1818

1919
describe('plugin:cache', function() {
20-
var PROBLEMS = [
20+
const PROBLEMS = [
2121
{id: 0, name: 'name0', slug: 'slug0', starred: false, category: 'algorithms'},
2222
{id: 1, name: 'name1', slug: 'slug1', starred: true, category: 'algorithms'}
2323
];
24-
var PROBLEM = {id: 0, slug: 'slug0', category: 'algorithms'};
24+
const PROBLEM = {id: 0, slug: 'slug0', category: 'algorithms'};
2525

26-
var NEXT = {};
26+
const NEXT = {};
2727

2828
before(function() {
2929
log.init();
@@ -132,11 +132,11 @@ describe('plugin:cache', function() {
132132
it('should ok', function() {
133133
cache.del('0.slug0.algorithms');
134134

135-
var problem = _.clone(PROBLEMS[0]);
135+
const problem = _.clone(PROBLEMS[0]);
136136
problem.locked = true;
137137
problem.state = 'ac';
138138

139-
var ret = plugin.saveProblem(problem);
139+
const ret = plugin.saveProblem(problem);
140140
assert.equal(ret, true);
141141
assert.deepEqual(cache.get('0.slug0.algorithms'),
142142
{id: 0, slug: 'slug0', name: 'name0', category: 'algorithms'});
@@ -147,8 +147,8 @@ describe('plugin:cache', function() {
147147
it('should updateProblem ok', function(done) {
148148
cache.set('problems', PROBLEMS);
149149

150-
var kv = {value: 'value00'};
151-
var ret = plugin.updateProblem(PROBLEMS[0], kv);
150+
const kv = {value: 'value00'};
151+
const ret = plugin.updateProblem(PROBLEMS[0], kv);
152152
assert.equal(ret, true);
153153

154154
plugin.getProblems(function(e, problems) {
@@ -163,20 +163,20 @@ describe('plugin:cache', function() {
163163

164164
it('should updateProblem fail if no problems found', function() {
165165
cache.del('problems');
166-
var ret = plugin.updateProblem(PROBLEMS[0], {});
166+
const ret = plugin.updateProblem(PROBLEMS[0], {});
167167
assert.equal(ret, false);
168168
});
169169

170170
it('should updateProblem fail if unknown problem', function() {
171171
cache.set('problems', [PROBLEMS[1]]);
172-
var ret = plugin.updateProblem(PROBLEMS[0], {});
172+
const ret = plugin.updateProblem(PROBLEMS[0], {});
173173
assert.equal(ret, false);
174174
});
175175
}); // #updateProblem
176176

177177
describe('#user', function() {
178-
var USER = {name: 'test-user', pass: 'password'};
179-
var USER_SAFE = {name: 'test-user'};
178+
const USER = {name: 'test-user', pass: 'password'};
179+
const USER_SAFE = {name: 'test-user'};
180180

181181
it('should login ok', function(done) {
182182
config.autologin.enable = true;

‎test/plugins/test_leetcode.js‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
11
'use strict';
2-
var _ = require('underscore');
3-
var assert = require('chai').assert;
4-
var nock = require('nock');
5-
var rewire = require('rewire');
2+
const _ = require('underscore');
3+
const assert = require('chai').assert;
4+
const nock = require('nock');
5+
const rewire = require('rewire');
66

7-
var config = require('../../lib/config');
8-
var log = require('../../lib/log');
7+
const config = require('../../lib/config');
8+
const log = require('../../lib/log');
99

10-
var plugin = rewire('../../lib/plugins/leetcode');
11-
var session = rewire('../../lib/session');
10+
const plugin = rewire('../../lib/plugins/leetcode');
11+
const session = rewire('../../lib/session');
1212

1313
describe('plugin:leetcode', function() {
14-
var USER = {hash: 'abcdef'};
15-
var PROBLEM = {
14+
const USER = {hash: 'abcdef'};
15+
const PROBLEM = {
1616
id: 389,
1717
name: 'Find the Difference',
1818
slug: 'find-the-difference',
1919
link: 'https://leetcode.com/problems/find-the-difference',
2020
locked: false,
2121
file: '/dev/null'
2222
};
23-
var SUBMISSION = {
23+
const SUBMISSION = {
2424
id: '73790064',
2525
lang: 'cpp',
2626
runtime: '9 ms',
@@ -537,7 +537,7 @@ describe('plugin:leetcode', function() {
537537

538538
describe('#getSubmissions', function() {
539539
it('should ok', function(done) {
540-
var problem = {
540+
const problem = {
541541
id: 1,
542542
name: 'Two Sum',
543543
slug: 'two-sum',
@@ -645,7 +645,7 @@ describe('plugin:leetcode', function() {
645645
plugin.getFavorites(function(e, favorites) {
646646
assert.equal(e, null);
647647

648-
var my = favorites.favorites.private_favorites;
648+
const my = favorites.favorites.private_favorites;
649649
assert.equal(my.length, 1);
650650
assert.equal(my[0].name, 'Favorite');
651651
assert.equal(my[0].id_hash, 'abcdefg');

‎test/plugins/test_retry.js‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
'use strict';
2-
var assert = require('chai').assert;
3-
var rewire = require('rewire');
2+
const assert = require('chai').assert;
3+
const rewire = require('rewire');
44

5-
var log = require('../../lib/log');
5+
const log = require('../../lib/log');
66

7-
var config = rewire('../../lib/config');
8-
var session = rewire('../../lib/session');
9-
var plugin = rewire('../../lib/plugins/retry');
7+
const config = rewire('../../lib/config');
8+
const session = rewire('../../lib/session');
9+
const plugin = rewire('../../lib/plugins/retry');
1010

1111
describe('plugin:retry', function() {
12-
var USER = {};
13-
var NEXT = {};
14-
var PROBLEMS = [{id: 0, name: 'name0'}];
12+
const USER = {};
13+
const NEXT = {};
14+
const PROBLEMS = [{id: 0, name: 'name0'}];
1515

1616
before(function() {
1717
log.init();
@@ -42,7 +42,7 @@ describe('plugin:retry', function() {
4242
it('should retry if session expired', function(done) {
4343
config.autologin.enable = true;
4444

45-
var n = 0;
45+
let n = 0;
4646
NEXT.getProblems = function(cb) {
4747
++n;
4848
if (n === 1) return cb(session.errors.EXPIRED);
@@ -63,7 +63,7 @@ describe('plugin:retry', function() {
6363
it('should fail if user expired locally', function(done) {
6464
config.autologin.enable = true;
6565

66-
var n = 0;
66+
let n = 0;
6767
NEXT.getProblems = function(cb) {
6868
++n;
6969
if (n === 1) return cb(session.errors.EXPIRED);

‎test/test_cache.js‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
'use strict';
2-
var execSync = require('child_process').execSync;
2+
const execSync = require('child_process').execSync;
33

4-
var assert = require('chai').assert;
5-
var rewire = require('rewire');
4+
const assert = require('chai').assert;
5+
const rewire = require('rewire');
66

7-
var cache = rewire('../lib/cache');
8-
var h = rewire('../lib/helper');
7+
const cache = rewire('../lib/cache');
8+
const h = rewire('../lib/helper');
99

1010
describe('cache', function() {
11-
var k = '.test';
12-
var v = {test: 'data'};
11+
const k = '.test';
12+
const v = {test: 'data'};
1313

1414
before(function() {
15-
var cachedir = './tmp';
15+
const cachedir = './tmp';
1616
execSync('rm -rf ' + cachedir);
1717

1818
h.getCacheDir = function() {
@@ -37,14 +37,14 @@ describe('cache', function() {
3737
});
3838

3939
it('should list ok when no cached', function() {
40-
var items = cache.list();
40+
const items = cache.list();
4141
assert.equal(items.length, 0);
4242
});
4343

4444
it('should list ok when cached', function() {
4545
assert.equal(cache.set(k, v), true);
4646

47-
var items = cache.list();
47+
const items = cache.list();
4848
assert.equal(items.length, 1);
4949

5050
assert.equal(items[0].name, k);

‎test/test_chalk.js‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
'use strict';
2-
var assert = require('chai').assert;
3-
var rewire = require('rewire');
2+
const assert = require('chai').assert;
3+
const rewire = require('rewire');
44

55
// refer to https://en.wikipedia.org/wiki/ANSI_escape_code
66
describe('chalk', function() {
77
it('should ok w/ 256 colors', function() {
8-
var chalk = rewire('../lib/chalk');
8+
const chalk = rewire('../lib/chalk');
99
chalk.enabled = true;
1010
chalk.use256 = true;
1111
chalk.init();
@@ -29,7 +29,7 @@ describe('chalk', function() {
2929
});
3030

3131
it('should ok w/ 8 colors', function() {
32-
var chalk = rewire('../lib/chalk');
32+
const chalk = rewire('../lib/chalk');
3333
chalk.enabled = true;
3434
chalk.use256 = false;
3535
chalk.init();
@@ -46,7 +46,7 @@ describe('chalk', function() {
4646
});
4747

4848
it('should ok w/o colors', function() {
49-
var chalk = rewire('../lib/chalk');
49+
const chalk = rewire('../lib/chalk');
5050
chalk.enabled = false;
5151
chalk.init();
5252
chalk.setTheme('default');
@@ -62,7 +62,7 @@ describe('chalk', function() {
6262
});
6363

6464
it('should sprint ok', function() {
65-
var chalk = rewire('../lib/chalk');
65+
const chalk = rewire('../lib/chalk');
6666
chalk.enabled = true;
6767
chalk.use256 = true;
6868
chalk.init();
@@ -75,7 +75,7 @@ describe('chalk', function() {
7575
});
7676

7777
it('should set theme ok', function() {
78-
var chalk = rewire('../lib/chalk');
78+
const chalk = rewire('../lib/chalk');
7979
chalk.enabled = true;
8080
chalk.use256 = true;
8181
chalk.init();
@@ -85,7 +85,7 @@ describe('chalk', function() {
8585
});
8686

8787
it('should set unknown theme ok', function() {
88-
var chalk = rewire('../lib/chalk');
88+
const chalk = rewire('../lib/chalk');
8989
chalk.enabled = true;
9090
chalk.use256 = true;
9191
chalk.init();

‎test/test_config.js‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
'use strict';
2-
var fs = require('fs');
2+
const fs = require('fs');
33

4-
var assert = require('chai').assert;
5-
var rewire = require('rewire');
6-
var _ = require('underscore');
4+
const assert = require('chai').assert;
5+
const rewire = require('rewire');
6+
const _ = require('underscore');
77

88
describe('config', function() {
9-
var config;
10-
var f = './tmp/config.json';
9+
let config;
10+
const f = './tmp/config.json';
1111

1212
beforeEach(function() {
1313
config = rewire('../lib/config');
14-
var h = rewire('../lib/helper');
14+
const h = rewire('../lib/helper');
1515
h.getConfigFile = function() {
1616
return f;
1717
};
@@ -25,11 +25,11 @@ describe('config', function() {
2525
it('should ok w/o local config', function() {
2626
if (fs.existsSync(f)) fs.unlinkSync(f);
2727

28-
var DEFAULT_CONFIG = config.__get__('DEFAULT_CONFIG');
28+
const DEFAULT_CONFIG = config.__get__('DEFAULT_CONFIG');
2929
config.init();
3030

31-
var actual = config.getAll();
32-
var expect = DEFAULT_CONFIG;
31+
let actual = config.getAll();
32+
let expect = DEFAULT_CONFIG;
3333
assert.deepEqual(actual, expect);
3434

3535
actual = config.getAll(true);
@@ -38,7 +38,7 @@ describe('config', function() {
3838
});
3939

4040
it('should ok w/ local config', function() {
41-
var data = {
41+
const data = {
4242
autologin: {enable: false},
4343
code: {lang: 'ruby'},
4444
color: {enable: false}
@@ -55,7 +55,7 @@ describe('config', function() {
5555
});
5656

5757
it('should remove legacy keys', function() {
58-
var data = {
58+
const data = {
5959
USE_COLOR: true,
6060
code: {lang: 'ruby'}
6161
};

0 commit comments

Comments
 (0)