New way of authorization for JsonApiCollection and pagination fixes

Author: d8vjork

src/Http/Resources/CollectsResources.php

@@ -0,0 +1,104 @@
+<?php
+
+namespace SkoreLabs\JsonApi\Http\Resources;
+
+use Illuminate\Http\Resources\MissingValue;
+use Illuminate\Support\Str;
+use Illuminate\Pagination\AbstractPaginator;
+use Illuminate\Pagination\LengthAwarePaginator;
+use Illuminate\Support\Facades\Auth;
+
+trait CollectsResources
+{
+    /**
+     * Map the given collection resource into its individual resources.
+     *
+     * @param  mixed  $resource
+     * @return mixed
+     */
+    protected function collectResource($resource)
+    {
+        if ($resource instanceof MissingValue) {
+            return $resource;
+        }
+
+        $collects = $this->collects();
+
+        $this->collection = $collects && ! $resource->first() instanceof $collects
+            ? $this->getFiltered($resource, $collects)
+            : $resource->toBase();
+
+        return $resource instanceof AbstractPaginator
+            ? $this->refreshPaginator($resource)
+            : $this->collection;
+    }
+
+    /**
+     * Undocumented function
+     *
+     * @param \Illuminate\Pagination\AbstractPaginator $resource
+     * @return void
+     */
+    protected function refreshPaginator(AbstractPaginator $resource)
+    {
+        return (new LengthAwarePaginator(
+            $this->collection,
+            $this->collection->count(),
+            $resource->perPage(),
+            $resource->currentPage(),
+            $resource->getOptions()
+        ))->setPageName($resource->getPageName());
+    }
+
+    /**
+     * Get resource collection filtered by authorization.
+     *
+     * @param mixed $resource
+     * @param mixed $collects
+     * @return \Illuminate\Support\Collection
+     */
+    protected function getFiltered($resource, $collects)
+    {
+        /** @var \Illuminate\Support\Collection $collection */
+        $collection = $resource->map(function ($item) use ($collects) {
+            $authorize = $this->authorize;
+
+            if (gettype($this->authorize) !== 'boolean') {
+                $authorize = Auth::user()->can('viewAny', class_basename($item));
+            }
+
+            return new $collects($item, $authorize);
+        });
+
+        return $collection->filter(function (JsonApiResource $item) {
+            return ! $item->resource instanceof MissingValue;
+        });
+    }
+
+    /**
+     * Get the resource that this resource collects.
+     *
+     * @return string|null
+     */
+    protected function collects()
+    {
+        if ($this->collects) {
+            return $this->collects;
+        }
+
+        if (Str::endsWith(class_basename($this), 'Collection') &&
+            class_exists($class = Str::replaceLast('Collection', '', get_class($this)))) {
+            return $class;
+        }
+    }
+
+    /**
+     * Get an iterator for the resource collection.
+     *
+     * @return \ArrayIterator
+     */
+    public function getIterator()
+    {
+        return $this->collection->getIterator();
+    }
+}

src/Http/Resources/Json/ResourceCollection.php

@@ -5,10 +5,9 @@
 use Countable;
 use IteratorAggregate;
 use Illuminate\Pagination\AbstractPaginator;
-use Illuminate\Http\Resources\CollectsResources;
-use Illuminate\Support\Facades\Auth;
 use SkoreLabs\JsonApi\Http\Resources\JsonApiResource;
 use Illuminate\Http\Resources\Json\PaginatedResourceResponse;
+use SkoreLabs\JsonApi\Http\Resources\CollectsResources;
 
 class ResourceCollection extends JsonApiResource implements Countable, IteratorAggregate
 {
@@ -36,8 +35,6 @@ class ResourceCollection extends JsonApiResource implements Countable, IteratorA
      */
     public function __construct($resource)
     {
-        parent::__construct($resource, Auth::user()->can('viewAny', get_class($resource)));
-
         $this->resource = $this->collectResource($resource);
     }
 
@@ -71,7 +68,7 @@ public function toArray($request)
     public function toResponse($request)
     {
         return $this->resource instanceof AbstractPaginator
-                    ? (new PaginatedResourceResponse($this))->toResponse($request)
-                    : parent::toResponse($request);
+            ? (new PaginatedResourceResponse($this))->toResponse($request)
+            : parent::toResponse($request);
     }
 }

src/Http/Resources/JsonApiCollection.php

@@ -12,11 +12,13 @@ class JsonApiCollection extends ResourceCollection
      * Create a new resource instance.
      *
      * @param  mixed  $resource
+     * @param  bool|null  $authorize
      * @return void
      */
-    public function __construct($resource)
+    public function __construct($resource, $authorize = null)
     {
         $this->collects = JsonApiResource::class;
+        $this->authorize = $authorize;
 
         parent::__construct($resource);
 

src/Http/Resources/JsonApiResource.php

@@ -21,7 +21,7 @@ class JsonApiResource extends JsonResource
      * Create a new resource instance.
      *
      * @param  mixed  $resource
-     * @param bool $authorize
+     * @param  bool|null  $authorize
      * @return void
      */
     public function __construct($resource, $authorize = null)