Tests: sort line numbers (#23)

* Tests: Sort getLineNumbersFromMessages

Sometimes the line numbers from warnings or errors are not in order.
This sorts the results making it easier to write tests for the line
numbers regardless of order.

* Tests: update tests for sorted line numbers

Author: sirbrillig

VariableAnalysis/Tests/BaseTestCase.php

@@ -19,7 +19,9 @@ public function prepareLocalFileForSniffs($sniffFiles, string $fixtureFile): Loc
   }
 
   public function getLineNumbersFromMessages(array $messages): array {
-    return array_keys($messages);
+    $lines = array_keys($messages);
+    sort($lines);
+    return $lines;
   }
 
   public function getWarningLineNumbersFromFile(LocalFile $phpcsFile): array {

VariableAnalysis/Tests/CodeAnalysis/VariableAnalysisTest.php

@@ -73,8 +73,8 @@ public function testFunctionWithGlobalVarWarnings() {
     $phpcsFile->process();
     $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
     $expectedWarnings = [
-      7,
       4,
+      7,
       22,
     ];
     $this->assertEquals($expectedWarnings, $lines);
@@ -214,8 +214,8 @@ public function testFunctionWithReferenceWarnings() {
     $phpcsFile->process();
     $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
     $expectedWarnings = [
-      20,
       8,
+      20,
       32,
       33,
       34,
@@ -363,13 +363,13 @@ public function testCompactWarnings() {
     $phpcsFile->process();
     $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
     $expectedWarnings = [
+      2,
       7,
       10,
-      2,
-      23,
-      26,
       14,
       19,
+      23,
+      26,
     ];
     $this->assertEquals($expectedWarnings, $lines);
   }