Add test to be sure option does not break other behavior

Author: sirbrillig

Tests/VariableAnalysisSniff/UnusedFollowedByRequireTest.php

@@ -4,7 +4,7 @@
 use VariableAnalysis\Tests\BaseTestCase;
 
 class UnusedFollowedByRequire extends BaseTestCase {
-  public function testUnusedFollowedByRequireDefault() {
+  public function testUnusedFollowedByRequireWarnsByDefault() {
     $fixtureFile = $this->getFixture('UnusedFollowedByRequireFixture.php');
     $phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);
     $phpcsFile->process();
@@ -26,7 +26,7 @@ public function testUnusedFollowedByRequireDefault() {
     $this->assertEquals($expectedWarnings, $lines);
   }
 
-  public function testUnusedFollowedByRequireWhenSet() {
+  public function testUnusedFollowedByRequireDoesNotWarnWhenSet() {
     $fixtureFile = $this->getFixture('UnusedFollowedByRequireFixture.php');
     $phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);
     $phpcsFile->ruleset->setSniffProperty(
@@ -44,4 +44,31 @@ public function testUnusedFollowedByRequireWhenSet() {
     ];
     $this->assertEquals($expectedWarnings, $lines);
   }
+
+  public function testUnusedFollowedByRequireDoesNotBreakOtherThingsWhenSet() {
+    $fixtureFile = $this->getFixture('FunctionWithoutParamFixture.php');
+    $phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);
+    $phpcsFile->ruleset->setSniffProperty(
+      'VariableAnalysis\Sniffs\CodeAnalysis\VariableAnalysisSniff',
+      'allowUnusedVariablesBeforeRequire',
+      'true'
+    );
+    $phpcsFile->process();
+    $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
+    $expectedWarnings = [
+      4,
+      5,
+      6,
+      7,
+      8,
+      9,
+      10,
+      11,
+      12,
+      13,
+      18,
+      19,
+    ];
+    $this->assertEquals($expectedWarnings, $lines);
+  }
 }