Support anonymous classes (#53)

* Tests: add test for $this and properties in anonymous classes

* findVariableScope, checkForThisWithinClass: consider anonymous classes

Author: loilo

VariableAnalysis/Lib/Helpers.php

@@ -174,7 +174,7 @@ public static function findVariableScope(File $phpcsFile, $stackPtr) {
         if (($scopeCode === T_FUNCTION) || ($scopeCode === T_CLOSURE)) {
           return $scopePtr;
         }
-        if (in_array($scopeCode, [T_CLASS, T_INTERFACE, T_TRAIT])) {
+        if (in_array($scopeCode, [T_CLASS, T_ANON_CLASS, T_INTERFACE, T_TRAIT])) {
           $in_class = true;
         }
       }

VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php

@@ -320,7 +320,7 @@ protected function checkForThisWithinClass(File $phpcsFile, $stackPtr, $varName,
       if ($tokens[$scopePtr]['code'] === T_CLOSURE) {
         return true;
       }
-      if ($scopeCode === T_CLASS || $scopeCode === T_TRAIT) {
+      if ($scopeCode === T_CLASS || $scopeCode === T_ANON_CLASS || $scopeCode === T_TRAIT) {
         return true;
       }
     }

VariableAnalysis/Tests/CodeAnalysis/VariableAnalysisTest.php

@@ -390,6 +390,18 @@ public function testTraitAllowsThis() {
     $this->assertEquals($expectedErrors, $lines);
   }
 
+  public function testAnonymousClassAllowsThis() {
+    $fixtureFile = $this->getFixture('AnonymousClassFixture.php');
+    $phpcsFile = $this->prepareLocalFileForSniffs($this->getSniffFiles(), $fixtureFile);
+    $phpcsFile->process();
+    $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
+    $expectedWarnings = [];
+    $this->assertEquals($expectedWarnings, $lines);
+    $lines = $this->getErrorLineNumbersFromFile($phpcsFile);
+    $expectedErrors = [];
+    $this->assertEquals($expectedErrors, $lines);
+  }
+
   public function testVariableFunctionCallsCountAsUsage() {
     $fixtureFile = $this->getFixture('FunctionWithVariableCallFixture.php');
     $phpcsFile = $this->prepareLocalFileForSniffs($this->getSniffFiles(), $fixtureFile);
@@ -414,6 +426,18 @@ public function testTraitsAllowPropertyDefinitions() {
     $this->assertEquals($expectedErrors, $lines);
   }
 
+  public function testAnonymousClassAllowPropertyDefinitions() {
+    $fixtureFile = $this->getFixture('AnonymousClassWithPropertiesFixture.php');
+    $phpcsFile = $this->prepareLocalFileForSniffs($this->getSniffFiles(), $fixtureFile);
+    $phpcsFile->process();
+    $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
+    $expectedWarnings = [];
+    $this->assertEquals($expectedWarnings, $lines);
+    $lines = $this->getErrorLineNumbersFromFile($phpcsFile);
+    $expectedErrors = [];
+    $this->assertEquals($expectedErrors, $lines);
+  }
+
   public function testUnusedParamsAreReported() {
     $fixtureFile = $this->getFixture('FunctionWithUnusedParamsFixture.php');
     $phpcsFile = $this->prepareLocalFileForSniffs($this->getSniffFiles(), $fixtureFile);

VariableAnalysis/Tests/CodeAnalysis/fixtures/AnonymousClassFixture.php

@@ -0,0 +1,11 @@
+<?php
+
+new class {
+    public function sayHelloWorld() {
+        echo 'Hello'.$this->getWorld();
+    }
+
+    protected function getWorld() {
+        return ' World!';
+    }
+};

VariableAnalysis/Tests/CodeAnalysis/fixtures/AnonymousClassWithPropertiesFixture.php

@@ -0,0 +1,10 @@
+<?php
+
+new class {
+    protected $storedHello;
+    public $helloOptions = [];
+    public function sayHelloWorld() {
+        echo "hello world";
+    }
+};
+