Remove UnusedParameter, since it is a breaking change

Author: sirbrillig

README.md

@@ -8,8 +8,6 @@ Plugin for PHP_CodeSniffer static analysis tool that adds analysis of problemati
 - Warns if variables are used for an array push shortcut without being defined. (Sniff code: `VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedArrayVariable`)
 - Warns if variables are used inside `unset()` without being defined. (Sniff code: `VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedUnsetVariable`)
 - Warns if variables are set or declared but never used. (Sniff code: `VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable`)
-- Warns if function parameters are declared but never used. (Sniff code: `VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter`)
-- Warns if function parameters are declared but never used before other parameters that are used. (Sniff code: `VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameterBeforeUsed`)
 - Warns if `$this`, `self::$static_member`, `static::$static_member` is used outside class scope. (Sniff codes: `VariableAnalysis.CodeAnalysis.VariableAnalysis.SelfOutsideClass` or `VariableAnalysis.CodeAnalysis.VariableAnalysis.StaticOutsideClass`)
 
 ## Installation

Tests/VariableAnalysisSniff/VariableAnalysisTest.php

@@ -628,13 +628,13 @@ public function testUnusedParamsHaveCorrectSniffCodes() {
     $phpcsFile->process();
 
     $warnings = $phpcsFile->getWarnings();
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameterBeforeUsed', $warnings[4][43][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter', $warnings[16][52][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter', $warnings[27][60][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter', $warnings[39][42][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter', $warnings[39][51][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter', $warnings[72][5][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter', $warnings[73][5][0]['source']);
+    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[4][43][0]['source']);
+    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[16][52][0]['source']);
+    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[27][60][0]['source']);
+    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[39][42][0]['source']);
+    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[39][51][0]['source']);
+    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[72][5][0]['source']);
+    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[73][5][0]['source']);
   }
 
   public function testValidUnusedVariableNamesIgnoresUnusedVariables() {

VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php

@@ -1696,14 +1696,6 @@ protected function processScopeCloseForVariable(File $phpcsFile, VariableInfo $v
       return;
     }
 
-    if ($varInfo->scopeType === ScopeType::PARAM && Helpers::areFollowingArgumentsUsed($varInfo, $scopeInfo)) {
-      $this->warnAboutUnusedParameterBeforeUsed($phpcsFile, $varInfo);
-      return;
-    }
-    if ($varInfo->scopeType === ScopeType::PARAM) {
-      $this->warnAboutUnusedParameterAfterUsed($phpcsFile, $varInfo);
-      return;
-    }
     $this->warnAboutUnusedVariable($phpcsFile, $varInfo);
   }
 
@@ -1728,48 +1720,6 @@ protected function warnAboutUnusedVariable(File $phpcsFile, VariableInfo $varInf
     }
   }
 
-  /**
-   * @param File $phpcsFile
-   * @param VariableInfo $varInfo
-   *
-   * @return void
-   */
-  protected function warnAboutUnusedParameterAfterUsed(File $phpcsFile, VariableInfo $varInfo) {
-    foreach (array_unique($varInfo->allAssignments) as $indexForWarning) {
-      Helpers::debug("variable {$varInfo->name} at end of scope looks unused");
-      $phpcsFile->addWarning(
-        "Unused %s %s.",
-        $indexForWarning,
-        'UnusedParameter',
-        [
-          VariableInfo::$scopeTypeDescriptions[$varInfo->scopeType],
-          "\${$varInfo->name}",
-        ]
-      );
-    }
-  }
-
-  /**
-   * @param File $phpcsFile
-   * @param VariableInfo $varInfo
-   *
-   * @return void
-   */
-  protected function warnAboutUnusedParameterBeforeUsed(File $phpcsFile, VariableInfo $varInfo) {
-    foreach (array_unique($varInfo->allAssignments) as $indexForWarning) {
-      Helpers::debug("variable {$varInfo->name} at end of scope looks unused");
-      $phpcsFile->addWarning(
-        "Unused %s %s.",
-        $indexForWarning,
-        'UnusedParameterBeforeUsed',
-        [
-          VariableInfo::$scopeTypeDescriptions[$varInfo->scopeType],
-          "\${$varInfo->name}",
-        ]
-      );
-    }
-  }
-
   /**
    * @param File $phpcsFile
    * @param string $varName