Skip to content

Commit 22f4228

Browse files
authored
Add test for UnusedParameterBeforeUsed sniff code (#206)
1 parent 87835f5 commit 22f4228

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

Tests/VariableAnalysisSniff/VariableAnalysisTest.php

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -617,6 +617,26 @@ public function testUnusedParamsAreReported() {
617617
$this->assertEquals($expectedWarnings, $lines);
618618
}
619619

620+
public function testUnusedParamsHaveCorrectSniffCodes() {
621+
$fixtureFile = $this->getFixture('FunctionWithUnusedParamsFixture.php');
622+
$phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);
623+
$phpcsFile->ruleset->setSniffProperty(
624+
'VariableAnalysis\Sniffs\CodeAnalysis\VariableAnalysisSniff',
625+
'allowUnusedParametersBeforeUsed',
626+
'false'
627+
);
628+
$phpcsFile->process();
629+
630+
$warnings = $phpcsFile->getWarnings();
631+
$this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameterBeforeUsed', $warnings[4][43][0]['source']);
632+
$this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter', $warnings[16][52][0]['source']);
633+
$this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter', $warnings[27][60][0]['source']);
634+
$this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter', $warnings[39][42][0]['source']);
635+
$this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter', $warnings[39][51][0]['source']);
636+
$this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter', $warnings[72][5][0]['source']);
637+
$this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedParameter', $warnings[73][5][0]['source']);
638+
}
639+
620640
public function testValidUnusedVariableNamesIgnoresUnusedVariables() {
621641
$fixtureFile = $this->getFixture('FunctionWithUnusedParamsFixture.php');
622642
$phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);

0 commit comments

Comments
 (0)