Remove php_errormsg from superglobals list (#269)

sirbrillig · web-flow · commit 0c1bfa3c424d · 2022-08-13T16:39:14.000-04:00
diff --git a/Tests/VariableAnalysisSniff/fixtures/FunctionWithGlobalVarFixture.php b/Tests/VariableAnalysisSniff/fixtures/FunctionWithGlobalVarFixture.php
@@ -67,7 +67,6 @@ function function_with_reserved_variables() {
   return [
     $response,
     $response_headers,
-    $php_errormsg,
     $HTTP_RAW_POST_DATA,
   ];
 }
diff --git a/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php b/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php
@@ -972,7 +972,6 @@ protected function processVariableAsSuperGlobal($varName)
 			'_ENV',
 			'argv',
 			'argc',
-			'php_errormsg',
 			'http_response_header',
 			'HTTP_RAW_POST_DATA',
 		];

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,6 @@ function function_with_reserved_variables() {`
`67`	`67`	`return [`
`68`	`68`	`$response,`
`69`	`69`	`$response_headers,`
`70`		`- $php_errormsg,`
`71`	`70`	`$HTTP_RAW_POST_DATA,`
`72`	`71`	`];`
`73`	`72`	`}`