[BUGFIX] sonarqube: Prefer Math.max() to simplify ternary expressions.

Ternary expressions should be replaced with "Math.min()" or "Math.max()" for simple comparisons typescript:S7766

Author: Gonzalo Diaz

src/hackerrank/interview_preparation_kit/dynamic_programming/max_array_sum.test.ts

@@ -1,7 +1,7 @@
 import { describe, expect, it } from '@jest/globals';
 import { logger as console } from '../../../logger';
 
-import { maxSubsetSum } from './max_array_sum';
+import { maxSubsetSum, bigIntMax } from './max_array_sum';
 
 import TEST_CASES from './max_array_sum.testcases.json';
 import TEST_CASE3 from './max_array_sum.testcase3.json';
@@ -10,6 +10,29 @@ const ALL_TEST_CASES = [...TEST_CASES, TEST_CASE3];
 
 const DECIMAL_RADIX = 10;
 
+describe('bigIntMax', () => {
+  it('bigIntMax test cases', () => {
+    expect.assertions(1);
+
+    const inputs = [1n, 3n, 2n, 5n, 4n];
+    const expected = 5n;
+
+    const answer = bigIntMax(...inputs);
+
+    console.debug(`bigIntMax(${inputs.toString()}) solution found: ${answer}`);
+
+    expect(answer).toStrictEqual(expected);
+  });
+
+  it('bigIntMax edge case', () => {
+    expect.assertions(1);
+
+    expect(() => {
+      bigIntMax();
+    }).toThrow('bigIntMax requires at least one argument.');
+  });
+});
+
 describe('max_array_sum', () => {
   it('maxSubsetSum test cases', () => {
     expect.assertions(5);

src/hackerrank/interview_preparation_kit/dynamic_programming/max_array_sum.ts

@@ -3,12 +3,17 @@
  * @see Solution Notes: [[docs/hackerrank/interview_preparation_kit/dynamic_programming/max_array_sum-solution-notes.md]]
  */
 
-const bigIntMax = (...args: bigint[]): bigint =>
-  args.reduce((m, e) => {
-    const _e = BigInt(e);
-    const _m = BigInt(m);
-    return _e > _m ? _e : _m;
-  }, BigInt(0));
+const bigIntMax = (...args: bigint[]): bigint => {
+  if (args.length === 0) {
+    throw new Error('bigIntMax requires at least one argument.');
+  }
+  return args.reduce((max, current) => {
+    if (current > max) {
+      return current;
+    }
+    return max;
+  }, 0n);
+};
 
 function maxSubsetSum(arr: number[]): number {
   const arrCopy: bigint[] = arr.map(BigInt);
@@ -36,4 +41,4 @@ function maxSubsetSum(arr: number[]): number {
 }
 
 export default { maxSubsetSum };
-export { maxSubsetSum };
+export { maxSubsetSum, bigIntMax };