Merge pull request #320 from sir-gon/develop

[BUGFIX] sonarcloud typescript:S6959 fixed.

Author: sir-gon

.github/workflows/node-coverage.js.yml

@@ -0,0 +1,50 @@
+name: Node.js CI Coverage
+
+on:
+  push:
+    branches: [ "main", "develop", "feature/*" ]
+  pull_request:
+    branches: [ "main" ]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        os: [
+            "ubuntu-latest"
+          ]
+        node-version: [20.x]
+        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4
+
+    - name: Set up Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v4
+      with:
+        node-version: ${{ matrix.node-version }}
+
+    - name: Install dependencies
+      run: npm ci --verbose
+
+    - name: Lint
+      run: npm run lint
+
+    - name: Run the tests
+      run: npm test -- --coverage
+
+    - name: Upload coverage reports to Codecov with GitHub Action
+      uses: codecov/codecov-action@v4
+      with:
+        token: ${{ secrets.CODECOV_TOKEN }} # required
+        verbose: true # optional (default = false)
+
+    - name: SonarCloud Scan
+      uses: SonarSource/sonarcloud-github-action@master
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
+        SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.github/workflows/node.js.yml

@@ -1,4 +1,4 @@
-name: Node.js CI
+name: Node.js CI Tests
 
 on:
   push:
@@ -37,10 +37,4 @@ jobs:
       run: npm run lint
 
     - name: Run the tests
-      run: npm test -- --coverage
-
-    - name: Upload coverage reports to Codecov with GitHub Action
-      uses: codecov/codecov-action@v4
-      with:
-        token: ${{ secrets.CODECOV_TOKEN }} # required
-        verbose: true # optional (default = false)
+      run: npm test

sonar-project.properties

@@ -0,0 +1,17 @@
+sonar.projectKey=sir-gon_algorithm-exercises-ts
+sonar.organization=sir-gon
+
+# This is the name and version displayed in the SonarCloud UI.
+#sonar.projectName=algorithm-exercises-ts
+#sonar.projectVersion=1.0
+
+
+# Path is relative to the sonar-project.properties file. Replace "\" by "/" on Windows.
+sonar.sources=src
+sonar.exclusions=**/*.json
+
+# Encoding of the source code. Default is default system encoding
+sonar.sourceEncoding=UTF-8
+
+# Coverage
+sonar.javascript.lcov.reportPaths=./coverage/lcov.info

src/projecteuler/problem0018.ts

@@ -31,7 +31,8 @@ export function problem0018(_triangle: number[][]): number {
   console.debug(`leafs count: ${leafs.length}`);
   console.debug(`leafs: ${leafs}`);
 
-  const max = leafs.reduce((a, b) => (a > b ? a : b));
+  const __START_FROM__ = 0;
+  const max = leafs.reduce((a, b) => (a > b ? a : b), __START_FROM__);
 
   return max;
 }