Skip to content

Commit 624b029

Browse files
author
Gonzalo Diaz
committed
[BUGFIX] sonarqube: Prefer .at(…) over [….length - index].
Complex index access patterns should be replaced with ".at()" method typescript:S7755
1 parent 0f7ad6c commit 624b029

File tree

4 files changed

+4
-7
lines changed

4 files changed

+4
-7
lines changed

src/hackerrank/interview_preparation_kit/greedy_algorithms/angry_children.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ function maxMin(k: number, arr: number[]): number {
77
.map((x: number): number => x)
88
.sort((a: number, b: number): number => a - b);
99

10-
let result = sortedlist[sortedlist.length - 1] - sortedlist[0];
10+
let result = (sortedlist.at(-1) ?? 0) - sortedlist[0];
1111

1212
for (let i = 0; i < sortedlist.length - k + 1; i++) {
1313
const tmin = sortedlist[i];

src/hackerrank/interview_preparation_kit/greedy_algorithms/minimum_absolute_difference_in_an_array.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ function minimumAbsoluteDifference(arr: number[]): number {
77
.map((x: number): number => x)
88
.sort((a: number, b: number): number => b - a);
99

10-
let result = Math.abs(sortedNums[sortedNums.length - 1] - sortedNums[0]);
10+
let result = Math.abs((sortedNums.at(-1) ?? 0) - sortedNums[0]);
1111

1212
for (let i = 0; i < sortedNums.length - 1; i++) {
1313
const aValue = sortedNums[i];

src/hackerrank/interview_preparation_kit/stacks_and_queues/balanced_brackets.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,7 @@ function isBalancedCompute(s: string): boolean {
1212
for (const letter of s.split('')) {
1313
if (letter in pairs) {
1414
brackets.push(letter);
15-
} else if (
16-
brackets.length > 0 &&
17-
pairs[brackets[brackets.length - 1]] === letter
18-
) {
15+
} else if (brackets.length > 0 && pairs[brackets.at(-1) ?? 0] === letter) {
1916
brackets.pop();
2017
} else {
2118
return false;

src/projecteuler/problem0007.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ function problem0007(_top: number): number {
2222

2323
console.log(`primes count: ${primes.length}`);
2424

25-
const answer = primes[primes.length - 1];
25+
const answer = primes.at(-1) ?? 0;
2626

2727
const cycles = i;
2828
console.log(`${_top} prime number is: ${answer} in ${cycles} cycles`);

0 commit comments

Comments
 (0)