Merge pull request #448 from sir-gon/develop

Develop

Author: sir-gon

.eslintrc

@@ -13,8 +13,8 @@
     "eslint:recommended",
     "plugin:@typescript-eslint/eslint-recommended",
     "plugin:@typescript-eslint/recommended",
-    // "plugin:@typescript-eslint/recommended-type-checked",
-    // "plugin:@typescript-eslint/stylistic-type-checked"
+    "plugin:@typescript-eslint/recommended-type-checked",
+    "plugin:@typescript-eslint/stylistic-type-checked",
     "airbnb-base",
     "prettier",
     "plugin:import/recommended",

src/constants/datetime.ts

@@ -19,9 +19,7 @@ export const __OCTOBER__ = 9;
 export const __NOVEMBER__ = 10;
 export const __DECEMBER__ = 11;
 
-interface MonthNames {
-  [key: string]: number;
-}
+type MonthNames = Record<string, number>;
 
 export const daysInMonth: MonthNames = {
   JANUARY: 31,
@@ -38,9 +36,7 @@ export const daysInMonth: MonthNames = {
   DECEMBER: 31
 };
 
-export interface MonthNumbers {
-  [key: string]: number;
-}
+export type MonthNumbers = Record<string, number>;
 
 export const daysInMonthNumber: MonthNumbers = {
   1: 31,

src/hackerrank/implementation/betweenTwoSets.test.ts

@@ -11,12 +11,16 @@ describe('betweenTwoSets', () => {
     const solutionFound = 0;
 
     const calculatedA = getTotalX([], input);
-    console.log(`Between Two Sets getTotalX([], ${input}): ${calculatedA}`);
+    console.log(
+      `Between Two Sets getTotalX([], ${input.toString()}): ${calculatedA}`
+    );
 
     expect(calculatedA).toBe(solutionFound);
 
     const calculatedB = getTotalX(input, []);
-    console.log(`Between Two Sets getTotalX(${input}, []): ${calculatedB}`);
+    console.log(
+      `Between Two Sets getTotalX(${input.toString()}, []): ${calculatedB}`
+    );
 
     expect(calculatedB).toBe(solutionFound);
 

src/hackerrank/implementation/birthday.ts

@@ -6,7 +6,7 @@ import { logger as console } from '../../logger';
 
 export function birthday(s: number[], d: number, m: number): number {
   let result = 0;
-  console.debug(`s: ${s}`);
+  console.debug(`s: ${s.toString()}`);
 
   for (let i = 0; i <= s.length - m; i++) {
     let sum = 0;

src/hackerrank/implementation/breakingRecords.test.ts

@@ -20,7 +20,9 @@ describe('breakingRecords', () => {
 
     const calculated = breakingRecords(input);
 
-    console.log(`breakingRecords(${input}) Test case 0: ${calculated}`);
+    console.log(
+      `breakingRecords(${input.toString()}) Test case 0: ${calculated.toString()}`
+    );
 
     expect(calculated).toStrictEqual(solutionFound);
   });
@@ -33,7 +35,9 @@ describe('breakingRecords', () => {
 
     const calculated = breakingRecords(input);
 
-    console.log(`breakingRecords(${input}) Test case 1: ${calculated}`);
+    console.log(
+      `breakingRecords(${input.toString()}) Test case 1: ${calculated.toString()}`
+    );
 
     expect(calculated).toStrictEqual(solutionFound);
   });

src/hackerrank/implementation/countApplesAndOranges.test.ts

@@ -7,10 +7,10 @@ describe('countApplesAndOranges', () => {
   it('countApplesAndOranges test case 0', () => {
     expect.assertions(1);
 
-    const s: number = 7;
-    const t: number = 11;
-    const a: number = 5;
-    const b: number = 15;
+    const s = 7;
+    const t = 11;
+    const a = 5;
+    const b = 15;
     const apples: number[] = [-2, 2, 1];
     const oranges: number[] = [5, -6];
     const solutionFound = [1, 1].join('\n');

src/hackerrank/implementation/gradingStudents.test.ts

@@ -12,7 +12,7 @@ describe('gradingStudents', () => {
 
     const calculated = gradingStudents(input);
 
-    console.log(`gradingStudents Test case 0: ${calculated}`);
+    console.log(`gradingStudents Test case 0: ${calculated.toString()}`);
 
     expect(calculated).toStrictEqual(solutionFound);
   });

src/hackerrank/implementation/migratoryBirds.ts

@@ -4,9 +4,7 @@
 
 import { logger as console } from '../../logger';
 
-interface Birds {
-  [name: string]: number;
-}
+type Birds = Record<string, number>;
 
 export function migratoryBirds(arr: number[]): number {
   if (arr.length === 0) {
@@ -32,7 +30,7 @@ export function migratoryBirds(arr: number[]): number {
       max = bird;
   }
 
-  console.debug(`map: ${map}`);
+  console.debug(`map: ${JSON.stringify(map)}`);
 
   return max;
 }

src/hackerrank/implementation/minimumAbsoluteDifference.ts

@@ -10,7 +10,7 @@ export function minimumAbsoluteDifference(arr: number[]): number {
   }
 
   const sortedNums = [...arr].sort((a: number, b: number) => a - b);
-  console.log(`sortedNums: ${sortedNums}`);
+  console.log(`sortedNums: ${sortedNums.toString()}`);
 
   let result: number = Math.abs(sortedNums[0] - sortedNums[1]);
 

src/hackerrank/implementation/sockMerchant.ts

@@ -7,9 +7,7 @@ import { logger as console } from '../../logger';
 export function sockMerchant(n: number, ar: number[]): number {
   let result = 0;
 
-  interface Matches {
-    [key: string]: number;
-  }
+  type Matches = Record<string, number>;
 
   const matches: Matches = {};