Skip to content

Commit 36b484c

Browse files
author
Gonzalo Diaz
committed
[BUGFIX] SonarQube: Prefer Number.parseInt over parseInt.
Number static methods and properties should be preferred over global equivalents typescript:S7773
1 parent a4d4968 commit 36b484c

File tree

12 files changed

+17
-16
lines changed

12 files changed

+17
-16
lines changed

src/hackerrank/interview_preparation_kit/miscellaneous/flipping-bits.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function flippingBits(n: number): number {
1919
}
2020
});
2121

22-
return parseInt(resultBinStr, __BINARY_BASE__);
22+
return Number.parseInt(resultBinStr, __BINARY_BASE__);
2323
}
2424

2525
export default { flippingBits };

src/hackerrank/interview_preparation_kit/recursion_and_backtracking/recursive_digit_sum.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ const __RADIX__ = 10;
66

77
function superDigitCompute(n: string): number {
88
if (n.length === 1) {
9-
return parseInt(n, __RADIX__);
9+
return Number.parseInt(n, __RADIX__);
1010
}
1111

1212
let partial = 0;
1313
for (const digit of n) {
14-
partial += parseInt(digit, __RADIX__);
14+
partial += Number.parseInt(digit, __RADIX__);
1515
}
1616

1717
return superDigitCompute(`${partial}`);

src/hackerrank/interview_preparation_kit/search/ctci_ice_cream_parlor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ function whatFlavorsCompute(cost: number[], money: number): number[] | null {
88
const cache: Record<number, number> = {};
99

1010
for (const [key, price] of Object.entries(cost)) {
11-
const i = parseInt(key, __RADIX__);
11+
const i = Number.parseInt(key, __RADIX__);
1212
const diff = money - price;
1313

1414
if (Number.isInteger(cache?.[diff])) {

src/hackerrank/interview_preparation_kit/search/ctci_ice_cream_parlor_bruteforce.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ function whatFlavorsBruteforceCompute(cost: number[], money: number): number[] {
66
const RADIX = 10;
77

88
for (const key of Object.keys(cost)) {
9-
const i: number = parseInt(key, RADIX);
9+
const i: number = Number.parseInt(key, RADIX);
1010
const x: number = cost[i];
1111

1212
const budget = money - x;

src/hackerrank/interview_preparation_kit/search/ctci_ice_cream_parlor_optimized.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ function whatFlavorsCompute(cost: number[], money: number): number[] {
1515
}
1616

1717
for (const key of Object.keys(cost)) {
18-
const i = parseInt(key, __RADIX__);
18+
const i = Number.parseInt(key, __RADIX__);
1919

2020
const v1 = cost[i];
2121
const v2 = money - v1;
@@ -35,7 +35,7 @@ function whatFlavorsCompute(cost: number[], money: number): number[] {
3535

3636
const result = new Set<number>();
3737
for (const key of Object.keys(cost)) {
38-
const x = parseInt(key, __RADIX__);
38+
const x = Number.parseInt(key, __RADIX__);
3939

4040
if (cost[x] === ans1 || cost[x] === ans2) {
4141
result.add(x + 1);

src/hackerrank/interview_preparation_kit/search/swap_nodes_algo.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,14 @@ function swapNodes(indexes: number[][], queries: number[]): number[][] {
104104

105105
nodeCollector = Object.fromEntries(
106106
Object.entries(nodeCollector).sort(
107-
([a], [b]) => parseInt(a, __RADIX__) - parseInt(b, __RADIX__)
107+
([a], [b]) =>
108+
Number.parseInt(a, __RADIX__) - Number.parseInt(b, __RADIX__)
108109
)
109110
);
110111

111112
for (const query of queries) {
112113
for (const [level, nodeList] of Object.entries(nodeCollector)) {
113-
const tLevel: number = parseInt(level, __RADIX__);
114+
const tLevel: number = Number.parseInt(level, __RADIX__);
114115

115116
if (tLevel % query === 0) {
116117
for (const node of nodeList) {

src/hackerrank/interview_preparation_kit/string_manipulation/sherlock_and_valid_string.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ function isValidCompute(s: string): boolean {
3434
);
3535
const __RADIX__ = 10;
3636
const __TOLERANCE__ = 1;
37-
const minorFreq: number = parseInt(frequenciesList[0][0], __RADIX__);
38-
const majorFreq: number = parseInt(frequenciesList[1][0], __RADIX__);
37+
const minorFreq: number = Number.parseInt(frequenciesList[0][0], __RADIX__);
38+
const majorFreq: number = Number.parseInt(frequenciesList[1][0], __RADIX__);
3939

4040
if (
4141
frequencies[minorFreq] === __TOLERANCE__ &&

src/hackerrank/warmup/solveMeFirst.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ function solveMeFirst(inputLines: string[]): number {
88
let result = 0;
99

1010
inputLines.forEach((v) => {
11-
result += parseInt(v, __RADIX__);
11+
result += Number.parseInt(v, __RADIX__);
1212
});
1313

1414
return result;

src/hackerrank/warmup/timeConversion.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ function timeConversion(s: string): string {
88

99
const timeStr = s.substring(0, s.length - 2);
1010
const time = timeStr.split(':');
11-
let hour = parseInt(time[0], 10);
11+
let hour = Number.parseInt(time[0], 10);
1212

1313
if (hour >= 12) {
1414
hour = 0;

src/projecteuler/problem0013-alt.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function problem0013alt(
1818

1919
console.debug(`Sum: ${sum}`);
2020

21-
const firstDigits = parseInt(
21+
const firstDigits = Number.parseInt(
2222
sum.toString().slice(0, numberOfFirstDigits),
2323
radix
2424
);

0 commit comments

Comments
 (0)