[BUGFIX] [Hacker Rank] Interview Preparation Kit: Dictionaries and Hashmaps: Frequency Queries.

* Fixed result. Fails due time out in big cases.
* Basic test cases added.

Author: Gonzalo Diaz

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/frequency_queries.test.ts renamed to src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/frequency_queries_bruteforce.test.ts

@@ -1,30 +1,14 @@
 import { describe, expect, it } from '@jest/globals';
 import { logger as console } from '../../../logger';
 
-import { freqQuery } from './frequency_queries';
-
-const TEST_CASES = [
-  {
-    title: 'Sample Test Case 0',
-    input: [
-      [1, 5],
-      [1, 6],
-      [3, 2],
-      [1, 10],
-      [1, 10],
-      [1, 6],
-      [2, 5],
-      [3, 2]
-    ],
-    expected: [0, 1]
-  }
-];
+import { freqQuery } from './frequency_queries_bruteforce';
+import SMALL_TEST_CASES from './frequency_queries_testcases.json';
 
 describe('frequency_queries', () => {
   it('freqQuery test cases', () => {
-    expect.assertions(1);
+    expect.assertions(4);
 
-    TEST_CASES.forEach((value) => {
+    SMALL_TEST_CASES.forEach((value) => {
       const answer = freqQuery(value.input);
 
       console.debug(`freqQuery(${value.input}) solution found: ${answer}`);

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/frequency_queries.ts renamed to src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/frequency_queries_bruteforce.ts

@@ -12,6 +12,9 @@ export function freqQuery(queries: number[][]): number[] {
   const __DELETE__ = 2;
   const __SELECT__ = 3;
 
+  const __NOT_FOUND__ = 0;
+  const __FOUND__ = 1;
+
   queries.forEach((query) => {
     const [operation, data] = query;
 
@@ -24,18 +27,15 @@ export function freqQuery(queries: number[][]): number[] {
       case __DELETE__:
         data_map[data] = Math.max(0, current - 1);
         break;
-      case __SELECT__:
-        for (const [key, value] of Object.entries(data_map)) {
-          console.log(key, value);
-          if (value == data) {
-            result.push(1);
-            break;
-          }
-        }
-        if (result.length == 0) {
-          result.push(0);
+      case __SELECT__: {
+        const uniqueDatavalues = new Set(Object.values(data_map));
+        if (uniqueDatavalues.has(data)) {
+          result.push(__FOUND__);
+        } else {
+          result.push(__NOT_FOUND__);
         }
         break;
+      }
       default:
         throw new Error('Invalid operation');
     }

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/frequency_queries_testcases.json

@@ -0,0 +1,68 @@
+[
+  {
+    "title": "Sample Test Case 0",
+    "input": [
+      [1, 5],
+      [1, 6],
+      [3, 2],
+      [1, 10],
+      [1, 10],
+      [1, 6],
+      [2, 5],
+      [3, 2]
+    ],
+    "expected": [0, 1]
+  },
+  {
+    "title": "Sample Test Case 1",
+    "input": [
+      [3, 4],
+      [2, 1003],
+      [1, 16],
+      [3, 1]
+    ],
+    "expected": [0, 1]
+  },
+  {
+    "title": "Sample Test Case 2",
+    "input": [
+      [1, 3],
+      [2, 3],
+      [3, 2],
+      [1, 4],
+      [1, 5],
+      [1, 5],
+      [1, 4],
+      [3, 2],
+      [2, 4],
+      [3, 2]
+    ],
+    "expected": [0, 1, 1]
+  },
+  {
+    "title": "Sample Test Case 3",
+    "input": [
+      [1, 3],
+      [1, 38],
+      [2, 1],
+      [1, 16],
+      [2, 1],
+      [2, 2],
+      [1, 64],
+      [1, 84],
+      [3, 1],
+      [1, 100],
+      [1, 10],
+      [2, 2],
+      [2, 1],
+      [1, 67],
+      [2, 2],
+      [3, 1],
+      [1, 99],
+      [1, 32],
+      [1, 58],
+      [3, 2]
+    ],
+    "expected": [1, 1, 0]
+  }
+]