[Hacker Rank] Interview Preparation Kit: Hash Tables: Ice Cream Parlor. Optimized solution ✅. Reducing complexity.

Cognitive Complexity of functions should not be too high typescript:S3776: https://sonarcloud.io/project/issues?pullRequest=437&open=AZFZr6GONPSO_orcN749&id=sir-gon_algorithm-exercises-ts

Author: Gonzalo Diaz

src/hackerrank/interview_preparation_kit/search/ctci_ice_cream_parlor_optimized.ts

@@ -3,8 +3,8 @@
  */
 
 export function whatFlavorsCompute(cost: number[], money: number): number[] {
-  let ans1;
-  let ans2;
+  let ans1: number | null = null;
+  let ans2: number | null = null;
 
   const CACHE: Record<number, number> = {};
 
@@ -16,19 +16,16 @@ export function whatFlavorsCompute(cost: number[], money: number): number[] {
     const v1 = cost[i];
     const v2 = money - v1;
 
-    if (v1 != v2) {
-      if (CACHE?.[v1] && CACHE?.[v2]) {
-        ans1 = v1;
-        ans2 = v2;
-        break;
-      }
-    } else {
-      // count of the element must be greater than 1 if they are same
-      if (CACHE?.[v1] && CACHE[v1] > 1) {
-        ans1 = v1;
-        ans2 = v1;
-        break;
-      }
+    if (v1 != v2 && CACHE?.[v1] && CACHE?.[v2]) {
+      ans1 = v1;
+      ans2 = v2;
+      break;
+    }
+
+    if (v1 == v2 && CACHE?.[v1] && CACHE[v1] > 1) {
+      ans1 = v1;
+      ans2 = v1;
+      break;
     }
   }