Merge pull request #780 from sir-gon/develop

Develop

Author: sir-gon

Makefile

@@ -33,6 +33,15 @@ DOCKER_COMPOSE=docker compose
 .PHONY: all clean dependencies help list test outdated
 .EXPORT_ALL_VARIABLES: # (2)
 
+define crono
+	@start=$$(date +%s); \
+		$(1); \
+		end=$$(date +%s); \
+		diff=$$((end - start)); \
+		printf "Total time: %02d:%02d:%02d\n" $$((diff/3600)) $$((diff%3600/60)) $$((diff%60))
+endef
+
+
 help: list
 
 list:
@@ -135,7 +144,8 @@ compose/test: compose/build
 compose/run: compose/build
 	${DOCKER_COMPOSE} --profile production run --rm algorithm-exercises-js make run
 
-all: env dependencies test
+all:
+	$(call crono, make clean && make dependencies && make build && make test && make lint && make coverage/html)
 
 run:
 	ls -alh

src/hackerrank/implementation/countingValleys.js

@@ -11,7 +11,7 @@ function countingValleys(steps, path) {
 
   console.debug(stepList);
 
-  stepList.forEach((step) => {
+  for (const step of stepList) {
     if (step === 'D') {
       if (altitude === 0) {
         valleys += 1;
@@ -21,7 +21,7 @@ function countingValleys(steps, path) {
     if (step === 'U') {
       altitude += 1;
     }
-  });
+  }
 
   return valleys;
 }

src/hackerrank/implementation/migratoryBirds.js

@@ -2,7 +2,7 @@
  * @link Problem definition [[docs/hackerrank/implementation/migratoryBirds.md]]
  */
 
-import util from 'util';
+import util from 'node:util';
 import { logger as console } from '../../logger.js';
 
 function migratoryBirds(arr) {
@@ -16,10 +16,10 @@ function migratoryBirds(arr) {
   for (const bird of arr) {
     console.debug(`bird ${bird}`);
 
-    if (!map[bird]) {
-      map[bird] = 1;
-    } else {
+    if (map[bird]) {
       map[bird] += 1;
+    } else {
+      map[bird] = 1;
     }
 
     console.debug(`bird = ${bird} ~> map[bird] = ${map[bird]}`);

src/hackerrank/implementation/repeatedString.js

@@ -9,11 +9,11 @@ function countAs(word) {
 
   const chars = word.split('');
 
-  chars.forEach((char) => {
+  for (const char of chars) {
     if (char === 'a') {
       result += 1;
     }
-  });
+  }
 
   return result;
 }

src/hackerrank/implementation/sockMerchant.js

@@ -9,9 +9,9 @@ function sockMerchant(n, ar) {
 
   const matches = {};
 
-  ar.forEach((v) => {
+  for (const v of ar) {
     matches[v] = matches?.[v] ? matches[v] + 1 : 1;
-  });
+  }
 
   console.debug(matches);
 

src/hackerrank/interview_preparation_kit/arrays/2d_array.test.js

@@ -8,15 +8,15 @@ describe('arrays: 2d Array hourglassSum', () => {
   it('hourglassSum Test Cases', () => {
     expect.assertions(4);
 
-    TEST_CASES.forEach((test) => {
+    for (const test of TEST_CASES) {
       const answer = hourglassSum(test.input);
 
       console.debug(
         `gethourGlass(${test.input.toString()}) solution found: ${answer}`
       );
 
       expect(answer).toStrictEqual(test.expected);
-    });
+    }
 
     expect(TEST_CASES).toHaveLength(3);
   });

src/hackerrank/interview_preparation_kit/arrays/cruch_bruteforce.js

@@ -11,19 +11,19 @@ function arrayManipulation(n, queries) {
   const result = Array(LENGTH).fill(SURROGATE_VALUE);
   let maximum = 0;
 
-  queries.forEach((query) => {
+  for (const query of queries) {
     const [aStart, bEnd, kValue] = query;
     console.debug(`start -> ${result}`);
 
     for (let i = aStart; i <= bEnd; i++) {
       result[i] += kValue;
       console.debug(`result -> ${result}`);
     }
-  });
+  }
 
-  result.forEach((value) => {
+  for (const value of result) {
     maximum = Math.max(value, maximum);
-  });
+  }
 
   return maximum;
 }

src/hackerrank/interview_preparation_kit/arrays/cruch_bruteforce.test.js

@@ -9,15 +9,15 @@ describe('arrays: crush (bruteforce) small cases', () => {
   it('arrayManipulation Test Cases', () => {
     expect.assertions(4);
 
-    TEST_CASES.forEach((test) => {
+    for (const test of TEST_CASES) {
       const answer = arrayManipulation(test.n, test.queries);
 
       console.debug(
         `arrayManipulation(${test.n}, ${test.queries}) solution found: ${answer}`
       );
 
       expect(answer).toStrictEqual(test.expected);
-    });
+    }
 
     expect(TEST_CASES).toHaveLength(3);
   });

src/hackerrank/interview_preparation_kit/arrays/cruch_optimized.js

@@ -11,19 +11,19 @@ function arrayManipulation(n, queries) {
   const result = Array(LENGTH).fill(INITIAL_VALUE);
   let maximum = 0;
 
-  queries.forEach((query) => {
+  for (const query of queries) {
     const [aStart, bEnd, kValue] = query;
 
     result[aStart] += kValue;
     result[bEnd + 1] -= kValue;
-  });
+  }
 
   let accumSum = 0;
 
-  result.forEach((value) => {
+  for (const value of result) {
     accumSum += value;
     maximum = Math.max(maximum, accumSum);
-  });
+  }
 
   return maximum;
 }

src/hackerrank/interview_preparation_kit/arrays/cruch_optimized.test.js

@@ -9,15 +9,15 @@ describe('arrays: crush (optimized)', () => {
   it('arrayManipulation Test Cases', () => {
     expect.assertions(4);
 
-    TEST_CASES.forEach((test) => {
+    for (const test of TEST_CASES) {
       const answer = arrayManipulation(test.n, test.queries);
 
       console.debug(
         `arrayManipulation(${test.n}, ${test.queries}) solution found: ${answer}`
       );
 
       expect(answer).toStrictEqual(test.expected);
-    });
+    }
 
     expect(TEST_CASES).toHaveLength(3);
   });