[BUGFIX] SonarQube: Prefer .at(…) over [….length - index].

Complex index access patterns should be replaced with ".at()" method javascript:S7755

Author: Gonzalo Diaz

src/hackerrank/interview_preparation_kit/greedy_algorithms/angry_children.js

@@ -5,7 +5,7 @@
 function maxMin(k, arr) {
   const sortedlist = arr.map((x) => x).sort((a, b) => a - b);
 
-  let result = sortedlist[sortedlist.length - 1] - sortedlist[0];
+  let result = sortedlist.at(-1) - sortedlist[0];
 
   for (let i = 0; i < sortedlist.length - k + 1; i++) {
     const tmin = sortedlist[i];

src/hackerrank/interview_preparation_kit/greedy_algorithms/minimum_absolute_difference_in_an_array.js

@@ -5,7 +5,7 @@
 function minimumAbsoluteDifference(arr) {
   const sortedNums = arr.map((x) => x).sort((a, b) => b - a);
 
-  let result = Math.abs(sortedNums[sortedNums.length - 1] - sortedNums[0]);
+  let result = Math.abs(sortedNums.at(-1) - sortedNums[0]);
 
   for (let i = 0; i < sortedNums.length - 1; i++) {
     const aValue = sortedNums[i];

src/hackerrank/interview_preparation_kit/stacks_and_queues/balanced_brackets.js

@@ -12,10 +12,7 @@ function isBalancedCompute(s) {
   for (const letter of s.split('')) {
     if (letter in pairs) {
       brackets.push(letter);
-    } else if (
-      brackets.length > 0 &&
-      pairs[brackets[brackets.length - 1]] === letter
-    ) {
+    } else if (brackets.length > 0 && pairs[brackets.at(-1)] === letter) {
       brackets.pop();
     } else {
       return false;

src/projecteuler/problem0007.js

@@ -23,7 +23,7 @@ function problem0007(_top) {
 
   console.log(`primes count: ${primes.length}`);
 
-  const answer = primes[primes.length - 1];
+  const answer = primes.at(-1);
 
   const cycles = i;
   console.log(`${_top} prime number is: ${answer} in ${cycles} cycles`);