[REFACTOR] Change {List-type property} to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)

Author: Gonzalo Diaz

src/algorithm_exercises_csharp/hackerrank/warmup/SimpleArraySum.cs

@@ -4,13 +4,13 @@ namespace algorithm_exercises_csharp.hackerrank.warmup;
 
 public static class SimpleArraySum
 {
-  public static int simpleArraySum(int[] inputs)
+  public static int simpleArraySum(List<int> ar)
   {
-    ArgumentNullException.ThrowIfNull(inputs);
+    ArgumentNullException.ThrowIfNull(ar);
 
     var total = 0;
 
-    foreach (int i in inputs)
+    foreach (int i in ar)
     {
       total += i;
     }

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/CrushBruteForce.Test.cs

@@ -5,12 +5,28 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.a
 [TestClass]
 public class CrushBruteForceTest
 {
-  public class CrushBruteForceTestCase
+  public class CrushBruteForceTestCase(string title, List<List<int>> queries, int n, long expected)
   {
-    public string title { get; set; } = default!;
-    public List<List<int>> queries { get; set; } = default!;
-    public int n { get; set; } = default!;
-    public long expected { get; set; } = default!;
+    private string title = title;
+    private List<List<int>> queries = queries;
+    private int n = n;
+    private long expected = expected;
+    public string Title
+    {
+      get { return title; }
+    }
+    public List<List<int>> Queries
+    {
+      get { return queries; }
+    }
+    public int N
+    {
+      get { return n; }
+    }
+    public long Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<CrushBruteForceTestCase> testCases { get; set; } = default!;
@@ -30,8 +46,8 @@ public void testArrayManipulation()
 
     foreach (CrushBruteForceTestCase test in testCases)
     {
-      result = CrushBruteForce.arrayManipulation(test.n, test.queries);
-      Assert.AreEqual(test.expected, result);
+      result = CrushBruteForce.arrayManipulation(test.N, test.Queries);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 }

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/CrushOptimized.Test.cs

@@ -5,12 +5,28 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.a
 [TestClass]
 public class CrushOptimizedTest
 {
-  public class CrushOptimizedTestCase
+  public class CrushOptimizedTestCase(string title, List<List<int>> queries, int n, long expected)
   {
-    public string title { get; set; } = default!;
-    public List<List<int>> queries { get; set; } = default!;
-    public int n { get; set; } = default!;
-    public long expected { get; set; } = default!;
+    private string title = title;
+    private List<List<int>> queries = queries;
+    private int n = n;
+    private long expected = expected;
+    public string Title
+    {
+      get { return title; }
+    }
+    public List<List<int>> Queries
+    {
+      get { return queries; }
+    }
+    public int N
+    {
+      get { return n; }
+    }
+    public long Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<CrushOptimizedTestCase> testCases { get; set; } = default!;
@@ -30,8 +46,8 @@ public void testArrayManipulation()
 
     foreach (CrushOptimizedTestCase test in testCases)
     {
-      result = CrushOptimized.arrayManipulation(test.n, test.queries);
-      Assert.AreEqual(test.expected, result);
+      result = CrushOptimized.arrayManipulation(test.N, test.Queries);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 }

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/NewYearChaos.Test.cs

@@ -5,11 +5,26 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.a
 [TestClass]
 public class NewYearChaosTest
 {
-  public class NewYearChaosTestCase
+  public class NewYearChaosTestCase(string title, int[] input, string expected)
   {
-    public string title { get; set; } = default!;
-    public List<int> input { get; set; } = default!;
-    public string expected { get; set; } = default!;
+    private readonly string title = title;
+    private readonly List<int> input = [.. input];
+    private readonly string expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+
+    public List<int> Input
+    {
+      get { return input; }
+    }
+
+    public string Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<NewYearChaosTestCase> testCases { get; set; } = default!;
@@ -29,10 +44,10 @@ public void testMinimumBribesText()
 
     foreach (NewYearChaosTestCase test in testCases)
     {
-      result = NewYearChaos.minimumBribesText(test.input);
-      NewYearChaos.minimumBribes(test.input);
+      result = NewYearChaos.minimumBribesText(test.Input);
+      NewYearChaos.minimumBribes(test.Input);
 
-      Assert.AreEqual(test.expected, result);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 }

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/TwoDArray.Test.cs

@@ -5,11 +5,24 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.a
 [TestClass]
 public class TwoDArrayTest
 {
-  public class TwoDArrayTestCase
+  public class TwoDArrayTestCase(string title, List<List<int>> input, long expected)
   {
-    public string title { get; set; } = default!;
-    public List<List<int>> input { get; set; } = default!;
-    public long expected { get; set; } = default!;
+    private string title = title;
+    private List<List<int>> input = input;
+    private long expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+    public List<List<int>> Input
+    {
+      get { return input; }
+    }
+    public long Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<TwoDArrayTestCase> testCases { get; set; } = default!;
@@ -29,8 +42,8 @@ public void testHourglassSum()
 
     foreach (TwoDArrayTestCase test in testCases)
     {
-      result = TwoDArray.hourglassSum(test.input);
-      Assert.AreEqual(test.expected, result);
+      result = TwoDArray.hourglassSum(test.Input);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTriplets.Test.cs

@@ -5,12 +5,32 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.d
 [TestClass]
 public class CountTripletsTest
 {
-  public class CountTripletsTestCase
+  public class CountTripletsTestCase(string title, long[] input, int r, long expected)
   {
-    public string title { get; set; } = default!;
-    public List<long> input { get; set; } = default!;
-    public int r { get; set; } = default!;
-    public long expected { get; set; } = default!;
+    private readonly string title = title;
+    private readonly List<long> input = [.. input];
+    private readonly int r = r;
+    private readonly long expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+
+    public List<long> Input
+    {
+      get { return input; }
+    }
+
+    public int R
+    {
+      get { return r; }
+    }
+
+    public long Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<CountTripletsTestCase> testCases { get; set; } = default!;
@@ -35,14 +55,14 @@ public void testCountTriplets()
 
     foreach (CountTripletsTestCase test in testCases)
     {
-      result = CountTriplets.countTriplets(test.input, test.r);
-      Assert.AreEqual(test.expected, result);
+      result = CountTriplets.countTriplets(test.Input, test.R);
+      Assert.AreEqual(test.Expected, result);
     }
 
     foreach (CountTripletsTestCase test in bigTestCases)
     {
-      result = CountTriplets.countTriplets(test.input, test.r);
-      Assert.AreEqual(test.expected, result);
+      result = CountTriplets.countTriplets(test.Input, test.R);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 }

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTripletsBruteForce.Test.cs

@@ -5,12 +5,32 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.d
 [TestClass]
 public class CountTripletsBruteForceTest
 {
-  public class CountTripletsBruteForceTestCase
+  public class CountTripletsBruteForceTestCase(string title, long[] input, int r, long expected)
   {
-    public string title { get; set; } = default!;
-    public List<long> input { get; set; } = default!;
-    public int r { get; set; } = default!;
-    public int expected { get; set; } = default!;
+    private readonly string title = title;
+    private readonly List<long> input = [.. input];
+    private readonly int r = r;
+    private readonly long expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+
+    public List<long> Input
+    {
+      get { return input; }
+    }
+
+    public int R
+    {
+      get { return r; }
+    }
+
+    public long Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<CountTripletsBruteForceTestCase> testCases { get; set; } = default!;
@@ -30,8 +50,8 @@ public void testCountTriplets()
 
     foreach (CountTripletsBruteForceTestCase test in testCases)
     {
-      result = CountTripletsBruteForce.countTriplets(test.input, test.r);
-      Assert.AreEqual(test.expected, result);
+      result = CountTripletsBruteForce.countTriplets(test.Input, test.R);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 }

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/FrequencyQueries.Test.cs

@@ -5,11 +5,24 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.d
 [TestClass]
 public class FrequencyQueriesTest
 {
-  public class FrequencyQueriesTestCase
+  public class FrequencyQueriesTestCase(string title, List<List<int>> input, List<int> expected)
   {
-    public string title { get; set; } = default!;
-    public List<List<int>> input { get; set; } = default!;
-    public List<int> expected { get; set; } = default!;
+    private string title = title;
+    private List<List<int>> input = input;
+    private List<int> expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+    public List<List<int>> Input
+    {
+      get { return input; }
+    }
+    public List<int> Expected
+    {
+      get { return expected; }
+    }
   }
 
   List<FrequencyQueriesTestCase> testCases { get; set; } = default!;
@@ -44,11 +57,11 @@ public void testFrequencyQueries()
 
     foreach (FrequencyQueriesTestCase test in testCases)
     {
-      solutionFound = FrequencyQueries.freqQuery(test.input);
+      solutionFound = FrequencyQueries.freqQuery(test.Input);
       CollectionAssert.AreEqual(
-        test.expected,
+        test.Expected,
         solutionFound,
-        $"FrequencyQueries.freqQuery({test.input}) answer must be: {test.expected}"
+        $"FrequencyQueries.freqQuery({test.Input}) answer must be: {test.Expected}"
       );
     }
   }
@@ -60,11 +73,11 @@ public void testFrequencyQueriesBigCases()
 
     foreach (FrequencyQueriesTestCase test in testCase6)
     {
-      solutionFound = FrequencyQueries.freqQuery(test.input);
+      solutionFound = FrequencyQueries.freqQuery(test.Input);
       CollectionAssert.AreEqual(
-        test.expected,
+        test.Expected,
         solutionFound,
-        $"FrequencyQueries.freqQuery({test.input}) answer must be: {test.expected}"
+        $"FrequencyQueries.freqQuery({test.Input}) answer must be: {test.Expected}"
       );
     }
   }
@@ -76,11 +89,11 @@ public void testFrequencyQueriesBorderCases()
 
     foreach (FrequencyQueriesTestCase test in testCaseBorderCases)
     {
-      solutionFound = FrequencyQueries.freqQuery(test.input);
+      solutionFound = FrequencyQueries.freqQuery(test.Input);
       CollectionAssert.AreEqual(
-        test.expected,
+        test.Expected,
         solutionFound,
-        $"FrequencyQueries.freqQuery({test.input}) answer must be: {test.expected}"
+        $"FrequencyQueries.freqQuery({test.Input}) answer must be: {test.Expected}"
       );
     }
   }
@@ -90,7 +103,7 @@ public void testFrequencyQueriesBorderCaseException()
   {
     foreach (FrequencyQueriesTestCase test in testCaseBorderCaseException)
     {
-      Assert.ThrowsExactly<InvalidOperationException>(() => _ = FrequencyQueries.freqQuery(test.input));
+      Assert.ThrowsExactly<InvalidOperationException>(() => _ = FrequencyQueries.freqQuery(test.Input));
     }
   }
 }